Fix OrderSettings transformer with inline comment #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug with the OrderSettings transformer where if a test case/keyword has a comment on the same line the output would be incorrect, e.g. given this input ```robot Test case # comment1 [Teardown] teardown [Documentation] this is Keyword1 # comment2 Keyword2 # comment3 Keyword3 ``` The expected output is: ```robot Test case # comment1 [Documentation] this is Keyword1 # comment2 Keyword2 # comment3 Keyword3 [Teardown] teardown ``` However before this patch the output would be: ```robot Test case [Documentation] this is # comment1 Keyword1 # comment2 Keyword2 # comment3 Keyword3 [Teardown] teardown ```
Member
|
Thank you for finding and fixing this issue - this PR looks really good :)! |
bhirsz
approved these changes
Oct 14, 2021
mnojek
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug with the OrderSettings transformer where if a
test case/keyword has a comment on the same line the output would be
incorrect, e.g. given this input
The expected output is:
However before this patch the output would be: