Skip to content

feat(bokeh): implement area-basic#295

Merged
github-actions[bot] merged 3 commits intoplot/area-basicfrom
auto/area-basic/bokeh
Dec 7, 2025
Merged

feat(bokeh): implement area-basic#295
github-actions[bot] merged 3 commits intoplot/area-basicfrom
auto/area-basic/bokeh

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude bot commented Dec 6, 2025

Summary

Implements area-basic for bokeh library.

Parent Issue: #201
Sub-Issue: #215
Base Branch: plot/area-basic
Attempt: 2/3

Implementation

  • plots/bokeh/varea/area-basic/default.py

Details

  • Uses varea method for filled area chart
  • Includes line overlay for clearer boundary
  • Monthly sales data from the spec (Jan-Dec)
  • Categorical x-axis with month label overrides
  • Python Blue (#306998) color with 70% opacity fill
  • 4800x2700px output per style guide
  • Font sizes: 20pt for title/axis labels, 16pt for tick labels
  • Subtle grid with 0.3 alpha

Dependencies

Added selenium>=4.15.0 and webdriver-manager>=4.0.0 to lib-bokeh optional dependency in pyproject.toml. This is required for bokeh's export_png() function.

⚠️ CI Fix Required (Workflow Permission)

The CI workflow needs Chrome setup for bokeh tests (similar to highcharts). A maintainer needs to update .github/workflows/ci-plottest.yml:

Change line 69-71 from:

- name: Setup Chrome for Highcharts
  if: steps.detect_libs.outputs.has_plots == 'true' && contains(steps.detect_libs.outputs.libraries, 'highcharts')

To:

- name: Setup Chrome for Bokeh/Highcharts
  if: steps.detect_libs.outputs.has_plots == 'true' && (contains(steps.detect_libs.outputs.libraries, 'highcharts') || contains(steps.detect_libs.outputs.libraries, 'bokeh'))

This cannot be pushed from this workflow due to GitHub App workflow permissions.

Local Test Result

The implementation runs successfully locally with Chrome and produces a valid 4800x2700 PNG.

Implements a basic area chart for bokeh library following KISS style:
- Uses varea method with fill_alpha=0.7
- Monthly sales data from spec
- Categorical x-axis with month labels
- Line overlay for clearer boundary
- 4800x2700px output size per style guide
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 6, 2025

✅ Plot Tests Passed

Python 3.13 (required): passed

Compatibility: 3.12 3.13

Note: Only Python 3.13 is required to pass. Python 3.12 is tested for compatibility.

github-actions bot and others added 2 commits December 7, 2025 00:53
Add selenium>=4.15.0 and webdriver-manager>=4.0.0 to lib-bokeh extra.
This is required for bokeh's export_png() function to work.

Note: ci-plottest.yml also needs to setup Chrome for bokeh tests
(requires manual update due to workflow permissions).
@claude claude bot added the ai-approved Quality OK, ready for merge label Dec 7, 2025
@github-actions github-actions bot merged commit ddf9a64 into plot/area-basic Dec 7, 2025
8 checks passed
@github-actions github-actions bot deleted the auto/area-basic/bokeh branch December 7, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-approved Quality OK, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant