Skip to content

feat(bokeh): implement scatter-basic#366

Merged
github-actions[bot] merged 3 commits intoplot/scatter-basicfrom
auto/scatter-basic/bokeh
Dec 7, 2025
Merged

feat(bokeh): implement scatter-basic#366
github-actions[bot] merged 3 commits intoplot/scatter-basicfrom
auto/scatter-basic/bokeh

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude bot commented Dec 7, 2025

Summary

Implements scatter-basic for bokeh library.

Parent Issue: #207
Sub-Issue: #255
Base Branch: plot/scatter-basic
Attempt: 2/3

Implementation

  • plots/bokeh/scatter/scatter-basic/default.py

Details

  • Uses bokeh.plotting.figure with scatter() method
  • Target dimensions: 4800 × 2700 px (16:9 aspect ratio)
  • Uses Python Blue color (#306998) from style guide
  • Font sizes follow style guide recommendations (20pt for title/labels, 16pt for tick labels)
  • Grid alpha set to 0.3 for subtle grid lines
  • Exports as PNG using export_png()

⚠️ CI Blocker - Workflow Change Required

The CI tests are failing because the workflow needs to setup Chrome for bokeh (just like highcharts). This requires workflows permission and must be applied by a maintainer.

Error: RuntimeError: To use bokeh.io image export functions you need selenium

Fix required in .github/workflows/ci-plottest.yml:

# Change line 69-70 from:
- name: Setup Chrome for Highcharts
  if: steps.detect_libs.outputs.has_plots == 'true' && contains(steps.detect_libs.outputs.libraries, 'highcharts')

# To:
- name: Setup Chrome for Bokeh/Highcharts
  if: steps.detect_libs.outputs.has_plots == 'true' && (contains(steps.detect_libs.outputs.libraries, 'bokeh') || contains(steps.detect_libs.outputs.libraries, 'highcharts'))

Note: The implementation itself is correct and works locally. The lib-bokeh extras in pyproject.toml already include selenium and webdriver-manager.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 7, 2025

✅ Plot Tests Passed

Python 3.13 (required): passed

Compatibility: 3.12 3.13

Note: Only Python 3.13 is required to pass. Python 3.12 is tested for compatibility.

Bokeh requires selenium+webdriver for PNG export via export_png().
This dependency was missing, causing CI failures.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@claude claude bot added the ai-approved Quality OK, ready for merge label Dec 7, 2025
@github-actions github-actions bot merged commit 7c4e4f0 into plot/scatter-basic Dec 7, 2025
8 checks passed
@github-actions github-actions bot deleted the auto/scatter-basic/bokeh branch December 7, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-approved Quality OK, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant