feat(bokeh): implement point-and-figure-basic

[github-actions]

Implementation: point-and-figure-basic - bokeh

Implements the bokeh version of point-and-figure-basic.

File: plots/point-and-figure-basic/implementations/bokeh.py

Parent Issue: #3755

---

🤖 impl-generate workflow

[claude]

AI Review - Attempt 1/3

Image Description

The plot displays a Point and Figure chart with green "X" symbols representing bullish (rising price) columns and red "O" symbols representing bearish (falling price) columns. The chart shows 9 columns (numbered 0-8 on x-axis) with prices ranging from approximately 78 to 122 on the y-axis. A blue ascending support trend line starts from the lower left (~77) and slopes upward to the right (~95). A yellow descending resistance trend line starts from the upper left (~123) and slopes downward to the right (~105). The title reads "point-and-figure-basic · bokeh · pyplots.ai". The legend shows "Support Trend" and "Resistance Trend" in the top left. The background is light gray (#fafafa) with subtle dashed grid lines. The X and O markers are appropriately sized and bold, making them clearly distinguishable.

Quality Score: 91/100

Criteria Checklist

Visual Quality (37/40 pts)

• VQ-01: Text Legibility (10/10) - All text perfectly readable: title at 48pt, axis labels at 36pt, tick labels at 28pt
• VQ-02: No Overlap (8/8) - No overlapping text or elements
• VQ-03: Element Visibility (8/8) - X and O markers at 48pt are optimal for data density
• VQ-04: Color Accessibility (5/5) - Green (#2E7D32) and red (#C62828) distinguishable; trend lines in blue and yellow provide additional contrast
• VQ-05: Layout Balance (3/5) - Good proportions but some empty space on the left side of the chart
• VQ-06: Axis Labels (2/2) - "Column (Reversal)" and "Price ($)" are descriptive with units
• VQ-07: Grid & Legend (1/2) - Grid is subtle at 0.3 alpha with dashed lines; legend placement is good but legend glyph sizes could better represent the actual markers

Spec Compliance (23/25 pts)

• SC-01: Plot Type (8/8) - Correct Point and Figure chart implementation
• SC-02: Data Mapping (5/5) - X-axis shows columns (reversals), Y-axis shows price - correct mapping
• SC-03: Required Features (4/5) - X's for rising, O's for falling, green/red colors, trend lines present; minor: grid lines not exactly at box size intervals
• SC-04: Data Range (3/3) - All data visible within axes
• SC-05: Legend Accuracy (1/2) - Legend only shows trend lines, not X/O meanings
• SC-06: Title Format (2/2) - Correct format: "point-and-figure-basic · bokeh · pyplots.ai"

Data Quality (19/20 pts)

• DQ-01: Feature Coverage (7/8) - Shows multiple columns of X's and O's, alternating trends, support/resistance lines; could show a clearer breakout pattern
• DQ-02: Realistic Context (7/7) - Stock price data from $78-122 with realistic daily returns including trending periods
• DQ-03: Appropriate Scale (5/5) - $2 box size with 3-box reversal is standard; 300 days of data is appropriate

Code Quality (9/10 pts)

• CQ-01: KISS Structure (3/3) - Linear script: imports → data generation → P&F calculation → plotting → save
• CQ-02: Reproducibility (3/3) - np.random.seed(42) set
• CQ-03: Clean Imports (2/2) - All imports are used
• CQ-04: No Deprecated API (1/1) - Uses current Bokeh API
• CQ-05: Output Correct (0/1) - Saves both plot.png and plot.html (correct) but uses underscore prefix _i in loop which is unnecessary

Library Features (3/5 pts)

• LF-01: Uses distinctive library features (3/5) - Uses ColumnDataSource, text glyphs, and HTML export; could utilize HoverTool for interactive tooltips showing date/price info

Strengths

• Excellent implementation of the P&F algorithm with proper box size and reversal logic
• Clean, readable code with proper data generation including realistic trending periods
• Good visual clarity with appropriately sized X and O markers
• Both PNG and HTML exports for static and interactive viewing
• Proper trend line implementation with 45-degree ascending/descending lines

Weaknesses

• Legend only shows trend lines, missing explanation of X (bullish) and O (bearish) meanings
• Grid lines not at exact box size intervals as suggested in spec
• Could add HoverTool for interactivity showing price/date information
• Minor empty space on left side of chart

Verdict: APPROVED