-
Notifications
You must be signed in to change notification settings - Fork 0
update(bubble-packed): plotly — comprehensive quality review #4360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
28cafa0
update(bubble-packed): plotly — comprehensive quality review
MarkusNeusinger e054a03
chore(plotly): update quality score 88 and review feedback for bubble…
github-actions[bot] 7c0a28b
fix(plotly): address review feedback for bubble-packed
github-actions[bot] c2163b5
chore(plotly): update quality score 85 and review feedback for bubble…
github-actions[bot] 5d16d84
fix(plotly): address review feedback for bubble-packed
github-actions[bot] 49b710e
chore(plotly): update quality score 89 and review feedback for bubble…
github-actions[bot] 81a2b12
fix(plotly): address review feedback for bubble-packed
github-actions[bot] 20ca72f
chore(plotly): update quality score 91 and review feedback for bubble…
github-actions[bot] 14802cb
Merge branch 'main' into implementation/bubble-packed/plotly
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,143 +1,178 @@ | ||
| """ pyplots.ai | ||
| bubble-packed: Basic Packed Bubble Chart | ||
| Library: plotly 6.5.0 | Python 3.13.11 | ||
| Quality: 93/100 | Created: 2025-12-23 | ||
| Library: plotly 6.5.2 | Python 3.14.3 | ||
| Quality: 91/100 | Updated: 2026-02-23 | ||
| """ | ||
|
|
||
| import numpy as np | ||
| import plotly.graph_objects as go | ||
|
|
||
|
|
||
| # Data - department budget allocation | ||
| np.random.seed(42) | ||
| data = { | ||
| "Marketing": 2800000, | ||
| "Engineering": 4500000, | ||
| "Sales": 3200000, | ||
| "Operations": 1800000, | ||
| "HR": 950000, | ||
| "Finance": 1200000, | ||
| "R&D": 3800000, | ||
| "Support": 1100000, | ||
| "Legal": 650000, | ||
| "IT": 2100000, | ||
| "Product": 1500000, | ||
| "QA": 880000, | ||
| "Data Science": 1650000, | ||
| "Design": 720000, | ||
| "Admin": 450000, | ||
| } | ||
|
|
||
| labels = list(data.keys()) | ||
| values = list(data.values()) | ||
|
|
||
| # Circle packing simulation using force-directed approach | ||
| # Data — department budgets with functional groupings | ||
| departments = [ | ||
| ("Engineering", 4500000, "Technology"), | ||
| ("R&D", 3800000, "Technology"), | ||
| ("IT", 2100000, "Technology"), | ||
| ("Data Science", 1650000, "Technology"), | ||
| ("QA", 880000, "Technology"), | ||
| ("Sales", 3200000, "Revenue"), | ||
| ("Marketing", 2800000, "Revenue"), | ||
| ("Operations", 1800000, "Operations"), | ||
| ("Finance", 1200000, "Operations"), | ||
| ("Support", 1100000, "Operations"), | ||
| ("Admin", 450000, "Operations"), | ||
| ("HR", 950000, "Corporate"), | ||
| ("Legal", 650000, "Corporate"), | ||
| ("Product", 1500000, "Corporate"), | ||
| ("Design", 720000, "Corporate"), | ||
| ] | ||
|
|
||
| labels = [d[0] for d in departments] | ||
| values = np.array([d[1] for d in departments]) | ||
| groups = [d[2] for d in departments] | ||
| n = len(labels) | ||
|
|
||
| # Group colors — colorblind-safe palette starting with Python Blue | ||
| group_colors = {"Technology": "#306998", "Revenue": "#E69F00", "Operations": "#009E73", "Corporate": "#CC79A7"} | ||
|
|
||
| # Scale radii by area (sqrt) for accurate visual perception | ||
| radii_scale = np.sqrt(np.array(values)) / np.sqrt(max(values)) * 100 | ||
| radii = np.sqrt(values / values.max()) * 110 | ||
|
|
||
| # Initial positions - spread in a circle | ||
| # Circle packing via force simulation | ||
| np.random.seed(42) | ||
| angles = np.linspace(0, 2 * np.pi, n, endpoint=False) | ||
| x_pos = np.cos(angles) * 200 + np.random.randn(n) * 50 | ||
| y_pos = np.sin(angles) * 200 + np.random.randn(n) * 50 | ||
| x_pos = np.cos(angles) * 150 + np.random.randn(n) * 30 | ||
| y_pos = np.sin(angles) * 150 + np.random.randn(n) * 30 | ||
|
|
||
| # Force simulation for circle packing | ||
| for _ in range(500): | ||
| for _ in range(600): | ||
| for i in range(n): | ||
| fx, fy = 0, 0 | ||
| # Centering force | ||
| fx -= x_pos[i] * 0.01 | ||
| fy -= y_pos[i] * 0.01 | ||
| # Repulsion between circles | ||
| fx, fy = -x_pos[i] * 0.01, -y_pos[i] * 0.01 | ||
| for j in range(n): | ||
| if i != j: | ||
| dx = x_pos[i] - x_pos[j] | ||
| dy = y_pos[i] - y_pos[j] | ||
| dist = np.sqrt(dx**2 + dy**2) + 0.1 | ||
| min_dist = radii_scale[i] + radii_scale[j] + 5 | ||
| min_dist = radii[i] + radii[j] + 4 | ||
| if dist < min_dist: | ||
| force = (min_dist - dist) * 0.3 | ||
| fx += (dx / dist) * force | ||
| fy += (dy / dist) * force | ||
| x_pos[i] += fx | ||
| y_pos[i] += fy | ||
|
|
||
| # Color palette - Python colors first, then colorblind-safe | ||
| colors = [ | ||
| "#306998", # Python Blue | ||
| "#FFD43B", # Python Yellow | ||
| "#4E79A7", | ||
| "#F28E2B", | ||
| "#E15759", | ||
| "#76B7B2", | ||
| "#59A14F", | ||
| "#EDC948", | ||
| "#B07AA1", | ||
| "#FF9DA7", | ||
| "#9C755F", | ||
| "#BAB0AC", | ||
| "#5778A4", | ||
| "#E49444", | ||
| "#85B6B2", | ||
| ] | ||
| # Weight-based centering for better visual balance (larger bubbles pull center) | ||
| area_weights = radii**2 | ||
| x_pos -= np.average(x_pos, weights=area_weights) | ||
| y_pos -= np.average(y_pos, weights=area_weights) | ||
|
|
||
| # Format values for display (inline) | ||
| formatted_values = [f"${v / 1000000:.1f}M" if v >= 1000000 else f"${v / 1000:.0f}K" for v in values] | ||
| # Format values for display | ||
| formatted = [f"${v / 1e6:.1f}M" if v >= 1e6 else f"${v / 1e3:.0f}K" for v in values] | ||
| shares = [f"{v / values.sum() * 100:.1f}" for v in values] | ||
| total = f"${values.sum() / 1e6:.1f}M" | ||
|
|
||
| # Create bubble chart | ||
| # Tight axis ranges for better canvas utilization | ||
| pad = 15 | ||
| x_lo = (x_pos - radii).min() - pad | ||
| x_hi = (x_pos + radii).max() + pad | ||
| y_lo = (y_pos - radii).min() - pad | ||
| y_hi = (y_pos + radii).max() + pad | ||
|
|
||
| # Convert data-coordinate radii to pixel marker diameters | ||
| fig_w, fig_h = 1600, 900 | ||
| m_l, m_r, m_t, m_b = 35, 35, 85, 85 | ||
| plot_w, plot_h = fig_w - m_l - m_r, fig_h - m_t - m_b | ||
| px_per_unit = min(plot_w / (x_hi - x_lo), plot_h / (y_hi - y_lo)) | ||
| marker_diameters = 2 * radii * px_per_unit | ||
|
|
||
| # Text colors for contrast against group backgrounds | ||
| text_colors = [] | ||
| for g in groups: | ||
| c = group_colors[g] | ||
| lum = 0.299 * int(c[1:3], 16) + 0.587 * int(c[3:5], 16) + 0.114 * int(c[5:7], 16) | ||
| text_colors.append("white" if lum < 160 else "#333") | ||
|
|
||
| # Build figure — one trace per group for idiomatic Plotly legend | ||
| fig = go.Figure() | ||
|
|
||
| # Add markers | ||
| fig.add_trace( | ||
| go.Scatter( | ||
| x=x_pos, | ||
| y=y_pos, | ||
| mode="markers", | ||
| marker=dict(size=radii_scale * 2, color=colors[:n], line=dict(color="white", width=2), opacity=0.85), | ||
| hovertemplate=[ | ||
| f"<b>{lbl}</b><br>{fval}<extra></extra>" for lbl, fval in zip(labels, formatted_values, strict=True) | ||
| ], | ||
| for group_name, group_color in group_colors.items(): | ||
| idx = [i for i in range(n) if groups[i] == group_name] | ||
| fig.add_trace( | ||
| go.Scatter( | ||
| x=x_pos[idx], | ||
| y=y_pos[idx], | ||
| mode="markers", | ||
| name=group_name, | ||
| marker={ | ||
| "size": marker_diameters[idx], | ||
| "sizemode": "diameter", | ||
| "color": group_color, | ||
| "opacity": 0.9, | ||
| "line": {"color": "white", "width": 2.5}, | ||
| }, | ||
| text=[labels[i] for i in idx], | ||
| customdata=np.column_stack( | ||
| [[formatted[i] for i in idx], [shares[i] for i in idx], [groups[i] for i in idx]] | ||
| ), | ||
| hovertemplate="<b>%{text}</b> (%{customdata[2]})<br>Budget: %{customdata[0]}<br>Share: %{customdata[1]}%<extra></extra>", | ||
| ) | ||
| ) | ||
| ) | ||
|
|
||
| # Add text annotations with size based on bubble radius | ||
| # Text labels inside bubbles — minimum 14pt for readability | ||
| for i in range(n): | ||
| font_size = max(10, min(18, int(radii_scale[i] * 0.2))) | ||
| font_size = max(14, min(20, int(radii[i] * 0.22))) | ||
| label_text = f"<b>{labels[i]}</b><br>{formatted[i]}" if radii[i] > 35 else f"<b>{labels[i]}</b>" | ||
| fig.add_annotation( | ||
| x=x_pos[i], | ||
| y=y_pos[i], | ||
| text=f"<b>{labels[i]}</b><br>{formatted_values[i]}", | ||
| text=label_text, | ||
| showarrow=False, | ||
| font=dict(size=font_size, color="white", family="Arial"), | ||
| font={"size": font_size, "color": text_colors[i], "family": "Arial"}, | ||
| ) | ||
|
|
||
| # Layout | ||
| fig.update_layout( | ||
| title=dict( | ||
| text="Department Budget Allocation · bubble-packed · plotly · pyplots.ai", | ||
| font=dict(size=32, color="#333"), | ||
| x=0.5, | ||
| xanchor="center", | ||
| ), | ||
| xaxis=dict( | ||
| showgrid=False, zeroline=False, showticklabels=False, title="", range=[min(x_pos) - 150, max(x_pos) + 150] | ||
| ), | ||
| yaxis=dict( | ||
| showgrid=False, | ||
| zeroline=False, | ||
| showticklabels=False, | ||
| title="", | ||
| scaleanchor="x", | ||
| scaleratio=1, | ||
| range=[min(y_pos) - 150, max(y_pos) + 150], | ||
| ), | ||
| title={ | ||
| "text": "Department Budget Allocation · bubble-packed · plotly · pyplots.ai", | ||
| "font": {"size": 32, "color": "#333"}, | ||
| "x": 0.5, | ||
| "xanchor": "center", | ||
| }, | ||
| xaxis={"showgrid": False, "zeroline": False, "showticklabels": False, "title": "", "range": [x_lo, x_hi]}, | ||
| yaxis={ | ||
| "showgrid": False, | ||
| "zeroline": False, | ||
| "showticklabels": False, | ||
| "title": "", | ||
| "scaleanchor": "x", | ||
| "scaleratio": 1, | ||
| "range": [y_lo, y_hi], | ||
| }, | ||
| template="plotly_white", | ||
| showlegend=False, | ||
| margin=dict(l=50, r=50, t=100, b=50), | ||
| legend={ | ||
| "font": {"size": 16, "family": "Arial"}, | ||
| "orientation": "h", | ||
| "yanchor": "top", | ||
| "y": -0.04, | ||
| "xanchor": "center", | ||
| "x": 0.5, | ||
| "itemsizing": "constant", | ||
| }, | ||
| margin={"l": m_l, "r": m_r, "t": m_t, "b": m_b}, | ||
| paper_bgcolor="white", | ||
| plot_bgcolor="white", | ||
| ) | ||
|
|
||
| # Save outputs | ||
| fig.write_image("plot.png", width=1600, height=900, scale=3) | ||
| # Total budget annotation below the cluster | ||
| fig.add_annotation( | ||
| text=f"Total: {total}", | ||
| xref="paper", | ||
| yref="paper", | ||
| x=0.5, | ||
| y=-0.01, | ||
| showarrow=False, | ||
| font={"size": 18, "color": "#666", "family": "Arial"}, | ||
| ) | ||
|
|
||
| # Save | ||
| fig.write_image("plot.png", width=fig_w, height=fig_h, scale=3) | ||
| fig.write_html("plot.html", include_plotlyjs=True, full_html=True) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description says the random seed was removed, but the implementation still sets
np.random.seed(42). Either update the PR description to match the code, or remove the seed here if that was the intended change.