-
Notifications
You must be signed in to change notification settings - Fork 0
update(bubble-packed): letsplot — comprehensive quality review #4366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ebb20b3
update(bubble-packed): letsplot — comprehensive quality review
MarkusNeusinger 80888a4
chore(letsplot): update quality score 85 and review feedback for bubb…
github-actions[bot] b385c6b
fix(letsplot): address review feedback for bubble-packed
github-actions[bot] 06d021b
chore(letsplot): update quality score 87 and review feedback for bubb…
github-actions[bot] 3cbe010
fix(letsplot): address review feedback for bubble-packed
github-actions[bot] 3fc6221
chore(letsplot): update quality score 86 and review feedback for bubb…
github-actions[bot] cebdd2d
fix(letsplot): address review feedback for bubble-packed
github-actions[bot] 74f0dca
chore(letsplot): update quality score 89 and review feedback for bubb…
github-actions[bot] 011e43f
Merge branch 'main' into implementation/bubble-packed/letsplot
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation now adds interactive tooltips, but it no longer exports
plot.html. That means the tooltip functionality won’t be available via the published HTML preview (and the metadata still points toplot.html). Either restore the HTML export or remove the HTML preview/tooltip setup so outputs and metadata stay consistent.