-
Notifications
You must be signed in to change notification settings - Fork 0
update(qrcode-basic): letsplot — scannable QR codes #5227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5d18919
update(qrcode-basic): letsplot — use real qrcode library for scannabl…
MarkusNeusinger 3fb2972
chore(letsplot): update quality score 85 and review feedback for qrco…
github-actions[bot] 338943a
chore(letsplot): update quality score 85 and review feedback for qrco…
github-actions[bot] c67cd85
fix(letsplot): address review feedback for qrcode-basic
github-actions[bot] b07a4ad
chore(letsplot): update quality score 90 and review feedback for qrco…
github-actions[bot] 15b544e
Merge branch 'main' into implementation/qrcode-basic/letsplot
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation now only saves
plot.png, but metadata still publishes apreview_htmlURL forplot.html. Either re-add exportingplot.html(common for lets-plot implementations) or update metadata to setpreview_html: nullso the published link doesn’t 404.