spec(area-mountain-panorama): require jagged ridgeline, forbid Gaussian peaks#5411
Merged
MarkusNeusinger merged 2 commits intomainfrom Apr 25, 2026
Merged
Conversation
…an peaks Generated implementations modelled summits as smooth Gaussian bumps, so the silhouette read like a row of bell curves instead of an alpine panorama. Spell out in the spec that the skyline must be piecewise-linear / fractal with sharp triangular peaks, asymmetric flanks and rugged saddles, and explicitly rule out Gaussian/bell-curve peaks. Add an optional layered foreground/background ridge note for photographic depth and tag the spec with `jagged`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the area-mountain-panorama plot specification to explicitly require a jagged, angular ridgeline silhouette (alpine panorama look) and prohibit smooth Gaussian/bell-curve peak modeling, so regenerated implementations better match the intended visual style.
Changes:
- Clarified
specification.mdto mandate piecewise-linear / fractal, triangular peak silhouettes and explicitly forbid Gaussian/bell-curve summits. - Added an optional “layered depth” note to encourage foreground/background ridge composition.
- Tagged the spec as
jaggedand updated the spec metadata timestamp.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
plots/area-mountain-panorama/specification.md |
Tightens the visual requirements for the skyline (jagged/triangular, not Gaussian) and adds optional depth layering guidance. |
plots/area-mountain-panorama/specification.yaml |
Updates updated timestamp and adds the jagged feature tag. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matplotlib.py:60-62), so the silhouette read like a row of bell curves instead of an alpine panorama.specification.mdthat the skyline must be piecewise-linear / fractal: sharp triangular peaks, asymmetric flanks, rugged saddles — and explicitly rule out Gaussian / bell-curve peak modelling.jaggedinspecification.yaml.Follow-up after merge
Re-trigger generation so all libraries pick up the new wording:
Test plan
🤖 Generated with Claude Code