chore(copilot): refresh .github/copilot-instructions.md to match current state#5554
Merged
MarkusNeusinger merged 3 commits intomainfrom Apr 29, 2026
Merged
Conversation
Several factual claims in .github/copilot-instructions.md had drifted out of sync with the codebase, which means Copilot's PR Reviewer was making decisions on stale ground rules. Bring back into agreement with what's actually in the repo: - Cloud Run service names: anyplot-api / anyplot-app (not -backend/-frontend) - Python: 3.13+ (matches pyproject.toml requires-python; 3.14 is unreleased) - Repair attempts: 4 (impl-repair.yml run-name: "attempt 1, 2, 3, or 4") - Quality threshold cascade: 90/80/70/60/50 across 4 repair rounds (the formula is THRESHOLD = max(50, 90 - attempt * 10) in impl-review.yml, not a single 90-or-50 check) Also drop the "No Co-authored-by in commit messages" rule per user direction — Claude Code's default attribution footer is fine. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refreshes .github/copilot-instructions.md so Copilot’s reviewer guidance matches the repository’s current CI/CD and workflow behavior.
Changes:
- Removes the “No Co-authored-by in commit messages” rule.
- Updates implementation review labeling docs to reflect the cascading quality threshold across up to 4 repair attempts.
- Corrects runtime/deployment facts (Python >= 3.13, Cloud Run service names
anyplot-api/anyplot-app).
| | Review # | Repair attempt | Threshold | | ||
| |----------|----------------|-----------| | ||
| | 1 (initial) | 0 | ≥ 90 | | ||
| | 2 | 1 | ≥ 80 | |
| ``` | ||
| [open] spec-request → approved → spec-ready [implementations can start] | ||
| ``` | ||
|
|
The actual layout under plots/{spec-id}/ is metadata/python/{lib}.yaml
and implementations/python/{lib}.py — confirmed via a directory listing
of plots/scatter-basic/ and plots/heatmap-basic/. The previous diagram
hid the python/ layer, which made path references in Copilot-generated
code wrong by one segment.
Add a short explanation that python/ is a forward-compatibility layer
for future non-Python implementation languages, and that the canonical
form of every path includes /python/.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Per Copilot review on PR #5554, both inline comments correctly flagged that the previous wording ("close PR and regenerate") implied automatic regeneration. Verified in .github/workflows/impl-review.yml the failure path runs `gh pr close` and posts a comment with options including "Regenerate from scratch with generate:$LIBRARY label" — which is a manual re-trigger, not a workflow-driven loop. Reword both the descriptive paragraph and the lifecycle diagram to match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several factual claims in `.github/copilot-instructions.md` had drifted out of sync with the actual codebase, which means GitHub Copilot's PR Reviewer was making decisions on stale ground rules.
What
Plus per user direction: drop the "No Co-authored-by in commit messages" rule. Claude Code's default attribution footer is fine.
PostgreSQL 18 is correct and unchanged (confirmed by user).
Test plan
🤖 Generated with Claude Code