chore: apply audit batch (lint repair + SEO/map + evaluator + docs)

[MarkusNeusinger]

Summary

Five quick-win items from agentic/audits/latest.md (2026-05-05):

1. Frontend lint CI repair — 32 errors → 0 (audit Critical Add workflow diagram for new prototype discovery #1).
2. /seo-proxy/map — bot prerender for the network map (audit Critical #5 partial).
3. evaluate-plot.py — switch to canonical 6-category rubric + bump model default (audit High Add Claude Code GitHub Workflow #2).
4. plausible.md — document FCP/TTFB Web-Vitals events (audit High Add Claude Code GitHub Workflow #3).
5. CodeQL [area-basic] seaborn implementation #101 — already user-dismissed 2026-05-05; called out in PR body, no code change.

Detail

1. Lint repair (yarn lint 32→0 errors)

• app/eslint.config.js: added IdleRequestCallback, IdleDeadline, IdleCallbackHandle, IdleRequestOptions, requestIdleCallback, cancelIdleCallback, FrameRequestCallback, IntersectionObserverCallback, IntersectionObserverInit, IntersectionObserverEntry to production globals; added Node global to test-entry globals.
• 5× react-hooks/set-state-in-effect: refactored to React 19's "adjust state on prop change" pattern (if (prev !== current) { setPrev(current); ... } during render — no cascading re-render):
  • RelatedSpecs.tsx — combined setExpanded(false) + setLoading(true) resets into a single prevDeps guard.
  • SpecDetailView.tsx — interactive size reset on selectedLibrary change.
  • DebugPage.tsx — setLoading(true)/setError(null) reset on [adminToken, reloadCounter] change.
  • SpecsListPage.tsx — random rotation init driven by Object.keys(rotationIndex).length === 0 guard (reference-compare on specList was attempted first but trips an infinite re-render in the test mock, which returns a fresh specsData array each call).
• 1× react-hooks/purity: Math.random in useFeaturedSpecs.ts extracted into a module-level pickRandom<T>(items) helper.
• 3× no-empty: sessionStorage swallows in DebugPage.tsx annotated with a comment.
• 1× unused var implNoPreview (SpecOverview.test.tsx): now used in the test (was a copy-paste oversight).
• 1× unused eslint-disable (MapPage.test.tsx:413) removed.

2. SEO /map handler

Mirrors the about/palette pattern in api/routers/seo.py. Bots now get a real <title> (Network Map | anyplot.ai) and a meta description.

3. evaluate-plot.py modernization

• Replace inline 5-category JSON template (Visual Quality 40 / Spec Compliance 25 / Data Quality 20 / Code Quality 10 / Library Features 5) with the canonical 6-category rubric driven by prompts/quality-evaluator.md + prompts/quality-criteria.md (Visual Quality 30 / Design Excellence 20 / Spec Compliance 15 / Data Quality 15 / Code Quality 10 / Library Mastery 10 = 100).
• print_quality_result and the --verbose loop updated to the new keys + denominators (was reading library_features / vq…/40 etc., now reads library_mastery / vq…/30).
• core/config.py: claude_model default bumped from claude-3-5-sonnet-20240620 (18 months old) to claude-sonnet-4-6.

4. Plausible docs (FCP/TTFB)

docs/reference/plausible.md: added FCP and TTFB rows to Custom Events table + Implementation Checklist; bumped total client-side events from 28 → 30.

⚠️ Follow-up needed: FCP/TTFB are already emitted from reportWebVitals.ts but must also be registered in the Plausible dashboard as custom events, otherwise they're silently dropped server-side. Documenting them here doesn't make them appear; that's a separate manual step.

5. CodeQL #101 — already dismissed

gh api repos/.../code-scanning/alerts/101 shows state: dismissed since 2026-05-05T21:38:46Z (dismissed by @MarkusNeusinger as "false positive — 'private' is a literal field name in a demo radar-chart axis dataset"). Audit was generated on the same day and listed it as still open. No code change in this PR for this item.

The audit's broader recommendation — "exclude plots/ from CodeQL scan" — would require switching from default to advanced code-scanning setup (workflow file + .github/codeql/codeql-config.yml). Not done here; left as a future hygiene task.

Test plan

• yarn lint → 0 errors (2 pre-existing react-refresh warnings unchanged)
• yarn tsc --noEmit → clean
• yarn test --run → 466/466 pass
• uv run ruff check api/ core/ → clean
• uv run ruff format --check api/ core/ → clean
• CI green on this PR (will watch)
• Post-merge: register FCP/TTFB in Plausible dashboard

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
app/src/components/RelatedSpecs.tsx	40.00%	3 Missing ⚠️
app/src/hooks/useFeaturedSpecs.ts	0.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This PR applies a small batch of “audit quick wins” across the frontend, API SEO proxy, evaluation tooling, and documentation to reduce CI lint noise, improve bot-facing metadata, and align plot evaluation with the canonical quality rubric.

Changes:

• Fix frontend lint issues by updating ESLint globals and refactoring several “set state in effect” patterns to render-phase state adjustments.
• Add a bot-optimized /seo-proxy/map endpoint with correct title/description meta tags for the network map page.
• Modernize scripts/evaluate-plot.py to compose prompts/quality-evaluator.md + prompts/quality-criteria.md, and update score printing to the 6-category rubric; bump the default Claude model in config.
• Document additional Web Vitals custom events (FCP/TTFB) in Plausible reference docs.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
scripts/evaluate-plot.py	Switch evaluation prompt to canonical evaluator + criteria and update category printing.
core/config.py	Update default claude_model.
api/routers/seo.py	Add /seo-proxy/map handler for bot prerender metadata.
docs/reference/plausible.md	Document FCP/TTFB events and update event totals.
app/eslint.config.js	Add missing globals used by frontend code/tests.
app/src/pages/SpecsListPage.tsx	Refactor rotation index initialization to avoid effect-based state setting.
app/src/pages/DebugPage.tsx	Refactor loading/error reset behavior and annotate sessionStorage no-ops.
app/src/components/RelatedSpecs.tsx	Refactor loading/reset logic to avoid state-setting-in-effect lint issues.
app/src/components/SpecDetailView.tsx	Reset interactive size on library change using render-phase adjustment.
app/src/hooks/useFeaturedSpecs.ts	Extract random selection into a helper for hook purity.
app/src/components/SpecOverview.test.tsx	Use previously-unused test variable to fix lint.
app/src/pages/MapPage.test.tsx	Remove unused ESLint disable.