chore(spec): auto-polish count-basic#5870
Merged
MarkusNeusinger merged 2 commits intomainfrom May 7, 2026
Merged
Conversation
Removed 'count' from plot_type tags (not in canonical vocabulary). The plot_type is fundamentally 'bar' with automatic aggregation captured in features. Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
MarkusNeusinger
added a commit
that referenced
this pull request
May 7, 2026
## Summary - Auto-polish PRs (e.g. #5916, #5870, #5860) were sitting open with all required checks green because the polish prompt explicitly forbade auto-merge — they piled up waiting for a human to click merge. - Patch the polish prompt to call \`gh pr merge --auto --squash --delete-branch\` right after \`gh pr create\`. Auto-merge handles the strict required-status-check rule on \`main\` by updating the branch automatically when behind. - Update the \"What you must NOT do\" section accordingly (remove \"do not auto-merge\", keep the \`approved\` label restriction and the no-\`--admin\` rule). - Rename the workflow step from \"opens PR — no auto-merge\" to \"opens PR with auto-merge\" so log titles match behavior. If \`gh pr merge --auto\` fails for any reason it falls back to a warning — the PR is still open and can be merged manually. ## Test plan - [ ] Next \`daily-regen\` cycle produces a polish PR with auto-merge enabled (visible via \`gh pr view <num> --json autoMergeRequest\`). - [ ] After CI passes, the PR squash-merges into main without manual intervention. - [ ] If the polish step finds nothing (\`NOOP\`), no PR is created (existing behavior). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
MarkusNeusinger
added a commit
that referenced
this pull request
May 7, 2026
) ## Summary First run of \`auto-update-pr-branches.yml\` after #5957 found 0 BEHIND PRs even though three were stuck behind main (#5916, #5870, #5902). Two issues: 1. **Timing.** The workflow runs ~4s after the push to main, but GitHub recomputes \`mergeStateStatus\` and the cached PR head SHA asynchronously. Right after the push the field is still UNKNOWN and the cached head can be stale → \`update-branch\` returns *expected head sha didn't match current head ref*. Add a 30s sleep at the start. 2. **Over-strict filter.** The script only iterated PRs where \`mergeStateStatus == "BEHIND"\`, skipping UNKNOWN candidates — exactly the ones we wanted to fix. Drop the filter: after a push to main, every open auto-merge PR is behind, and \`update-branch\` is a no-op when the head is already up-to-date. Also: - Bump permissions to \`contents: write\` (update-branch creates a merge commit on the head ref). - Drop \`--silent\` and capture stderr so the actual GitHub error lands in the log. Verified manually: calling \`PUT /pulls/{num}/update-branch\` from the CLI on #5916 and #5870 worked and they auto-merged within seconds. The 422 on #5902 was a real history-divergence conflict (4 ahead / 58 behind / merge_base differs) — separate problem. ## Test plan - [ ] After this merges, push something to main and confirm the workflow finds N>0 PRs (where N is open auto-merge PRs). - [ ] Confirm any genuinely stuck PR (conflict) gets a clear error in the log instead of \`likely conflict or stale ref\`. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated spec polish from
daily-regenpre-flight.Spec:
count-basicWhat changed
counttag fromplot_typedimensionWhy
The
counttag is not in the canonicalplot_typevocabulary. A count plot is fundamentally a bar chart (plot_type: bar) with automatic aggregation, which is already captured by theaggregationfeature tag. The audit rules require allplot_typetags to be canonical; non-canonical tags must be moved to the correct dimension or dropped.countdescribes a behavioral feature (automatic counting), not the visual form, so it was removed.Hard guarantees from the prompt
id,issue,createdunchangedupdatedbumped to current UTCAwaiting human review. The skip-gate in
daily-regenwill preventadditional auto-polish PRs for this spec while this one is open.