Integrate prompts and actions into unit tests by MarkusNeusinger · Pull Request #69 · MarkusNeusinger/anyplot

MarkusNeusinger · 2025-11-30T17:22:28Z

No description provided.

@master

Add comprehensive tests covering: Prompts: - File existence (all expected prompts present) - Required sections (Role, Task, Rules, etc.) - No placeholder text (TODO, FIXME, etc.) - Cross-reference validation (internal links work) - Consistency across library prompts - Code block language specification Workflows: - Valid YAML syntax - Required fields (name, on, jobs) - Security best practices (no hardcoded secrets) - Action version pinning (no @main/@master) - Valid trigger events - Proper permissions All 266 tests pass with ruff formatting applied.

Add comprehensive tests for core/images.py (31 tests total): - TestOptimizePng: 4 new tests for PNG optimization - TestAddWatermarkExtended: 4 tests for spec_id, font_size, padding - TestCreateThumbnailExtended: 4 tests for default width, portrait/square images - TestErrorCases: 3 tests for FileNotFoundError handling - TestImageFormats: 3 tests for RGBA, grayscale, large images - TestProcessPlotImage: 3 additional tests for spec_id, optimization toggle Improves coverage from ~60% to ~95% for core/images.py

Add 21 tests for api/main.py covering: - TestRootEndpoint: welcome message, version, URLs (4 tests) - TestHealthEndpoint: status, service name, version (4 tests) - TestHelloEndpoint: greetings, special chars, unicode (5 tests) - TestOpenAPIDocumentation: /docs, /redoc, /openapi.json (3 tests) - TestCORSMiddleware: localhost origins, headers (2 tests) - TestAppConfiguration: title, version, description (3 tests) Total test count now: 321

codecov · 2025-11-30T17:23:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

This PR adds comprehensive unit tests for GitHub Actions workflows, AI prompts, and API endpoints, significantly expanding test coverage for infrastructure and configuration files. The tests validate file existence, structure, security practices, and adherence to conventions across workflows and prompts, while also adding extended test coverage for the image processing module and new tests for the FastAPI application.

Key changes:

New test suites for GitHub Actions workflows (385 lines) validating YAML structure, security best practices, action versioning, and naming conventions
New test suites for AI prompts (276 lines) checking file structure, cross-references, placeholder absence, and consistency
Extended tests for core image processing functions covering edge cases like RGBA/grayscale images, portrait orientation, and optimization
New comprehensive tests for FastAPI endpoints including root, health, hello, CORS, and OpenAPI documentation

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
tests/unit/workflows/test_workflows.py	Comprehensive test suite for GitHub Actions workflows covering YAML validity, structure, security, versioning, naming, and triggers. Contains some logical issues in assertions.
tests/unit/workflows/init.py	Package initialization for workflow tests
tests/unit/prompts/test_prompts.py	Test suite for AI prompt files validating structure, placeholders, cross-references, and consistency. Contains regex and logic issues.
tests/unit/prompts/init.py	Package initialization for prompt tests
tests/unit/core/test_images.py	Extended tests for image processing functions including new optimize_png tests and edge cases for thumbnails and watermarks
tests/unit/api/test_main.py	New comprehensive test suite for FastAPI main endpoints. Contains CORS test issue.
tests/unit/api/init.py	Package initialization for API tests

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot · 2025-11-30T17:27:07Z

+        optimize_png(str(sample_image), str(output_path))
+
+        assert output_path.exists()
+
+


[nitpick] The function call optimize_png(str(sample_image), str(output_path)) doesn't verify the return value or check that the output file was actually created. While the next line checks assert output_path.exists(), there's no assertion about the return value being an integer (as tested in other test methods).

Consider adding: bytes_saved = optimize_png(str(sample_image), str(output_path)) and assert isinstance(bytes_saved, int) for consistency with test_optimizes_image and test_accepts_path_objects.

Suggested change

optimize_png(str(sample_image), str(output_path))

assert output_path.exists()

bytes_saved = optimize_png(str(sample_image), str(output_path))

assert output_path.exists()

assert isinstance(bytes_saved, int)

Copilot · 2025-11-30T17:27:07Z

+        )
+
+        # Should not be blocked
+        assert response.status_code in [200, 204, 400]


The CORS test allows status codes [200, 204, 400] which includes 400 (Bad Request). A 400 status code typically indicates an error, not a successful CORS preflight response.

For OPTIONS preflight requests, valid success responses are typically 200 or 204. If the server returns 400, it usually indicates a problem with the request. Consider changing to:

assert response.status_code in [200, 204], f"Unexpected status: {response.status_code}"

Suggested change

assert response.status_code in [200, 204, 400]

assert response.status_code in [200, 204], f"Unexpected status: {response.status_code}"

Copilot · 2025-11-30T17:27:07Z

+        # These are valid - just make sure they're using proper naming
+        for secret_name in secret_refs:
+            assert secret_name.isupper(), f"Secret name should be UPPER_CASE: {secret_name}"
+            assert "_" in secret_name or len(secret_name) > 3, f"Secret name too short: {secret_name}"


[nitpick] The secret name validation logic assert "_" in secret_name or len(secret_name) > 3 allows very short secret names (4+ characters) without underscores, such as ABCD or KEY1. This seems overly permissive.

Typical secret naming conventions require uppercase letters with underscores (e.g., API_KEY, DB_PASSWORD). Consider changing to:

assert "_" in secret_name or len(secret_name) >= 6, f"Secret name too short or missing underscore: {secret_name}"

Or enforce that all multi-word secrets must use underscores:

assert secret_name.isupper() and (len(secret_name) <= 4 or "_" in secret_name), f"Invalid secret name format: {secret_name}"

Suggested change

assert "_" in secret_name or len(secret_name) > 3, f"Secret name too short: {secret_name}"

assert "_" in secret_name or len(secret_name) >= 6, f"Secret name too short or missing underscore: {secret_name}"

Copilot · 2025-11-30T17:27:08Z

+        r"\{TODO\}",
+        r"\bTODO\b",
+        r"\bFIXME\b",
+        r"\bXXX\b",


The placeholder pattern r"\bXXX\b" uses word boundaries \b which won't match XXX when it appears in contexts like XXX: or (XXX) because the boundary between a letter and punctuation is not considered a word boundary in all cases.

Consider changing to: r"XXX" (without word boundaries) or use a more specific pattern like r"\bXXX\b|\bXXX[:\)]" if you want to catch common placeholder usages.

Suggested change

r"\bXXX\b",

r"XXX",

Copilot · 2025-11-30T17:27:08Z

+    "bot-ai-review.yml",
+    "bot-auto-merge.yml",
+    "bot-auto-tag.yml",
+    "bot-sync-status.yml",


The expected workflows list is missing two workflows that exist in the repository:

bot-link-issue.yml

util-claude.yml

These workflow files exist in .github/workflows/ but are not included in EXPECTED_WORKFLOWS, which will cause test_expected_workflow_exists to pass without verifying these files exist, and may cause false negatives in other tests that iterate over this list.

Suggested change

"bot-sync-status.yml",

"bot-sync-status.yml",

"bot-link-issue.yml",

"util-claude.yml",

Copilot · 2025-11-30T17:27:08Z

+            if file_words and name_words:
+                overlap = file_words & name_words
+                # This is a soft check - just ensure there's some relation
+                assert len(overlap) >= 0, f"Workflow name unrelated to file: {filepath.name}"


The test assertion assert len(overlap) >= 0 will always pass since the length of a set is always non-negative. This makes the test ineffective.

Consider changing to assert len(overlap) > 0 if you want to enforce that at least one word overlaps, or remove this assertion entirely since the comment says "very lenient check" and the condition is always true.

Suggested change

assert len(overlap) >= 0, f"Workflow name unrelated to file: {filepath.name}"

assert len(overlap) > 0, f"Workflow name unrelated to file: {filepath.name}"

Copilot · 2025-11-30T17:27:09Z

+        if "git log" in content or "git diff" in content:
+            has_fetch_depth = "fetch-depth:" in content or "fetch-depth :" in content
+            # Soft check - it's good practice but not strictly required
+            assert has_fetch_depth or True  # Always passes, but documents the practice


The assertion assert has_fetch_depth or True will always pass because of the or True condition. This makes the test ineffective at catching missing fetch-depth configurations.

If this is intentionally a soft check, consider either:

Removing the test entirely if it's not enforcing anything

Making it a proper assertion: assert has_fetch_depth, f"Missing fetch-depth in {filepath.name} which uses git log/diff"

Converting to a warning using pytest.warns if you want it to be informational

Copilot · 2025-11-30T17:27:09Z

+            # Filter out intentionally minimal sections
+            real_empty = [m for m in matches if len(m.strip()) < 20]
+            assert not real_empty, f"Found empty sections in {filepath.name}: {real_empty}"


The condition len(m.strip()) < 20 in the filter is checking the length of the matched header line, but the regex empty_section_pattern is designed to match sections with no content between headers. This logic appears incorrect.

The regex r"^## .+\n\s*(?=^## |\Z)" matches a header followed by optional whitespace before another header or end of file. The matched text m will be something like "## Header\n ", and checking if its stripped length is less than 20 doesn't effectively identify empty sections - it would filter out most matches since header text alone (e.g., "## Import") is typically less than 20 characters.

Consider revising the logic to properly identify truly empty sections, or remove the filter if all matched sections should be considered empty.

Suggested change

# Filter out intentionally minimal sections

real_empty = [m for m in matches if len(m.strip()) < 20]

assert not real_empty, f"Found empty sections in {filepath.name}: {real_empty}"

# All matches are considered empty sections

assert not matches, f"Found empty sections in {filepath.name}: {matches}"

claude added 3 commits November 30, 2025 16:35

Copilot AI review requested due to automatic review settings November 30, 2025 17:22

Copilot started reviewing on behalf of MarkusNeusinger November 30, 2025 17:22 View session

MarkusNeusinger merged commit d71ba33 into main Nov 30, 2025
7 checks passed

MarkusNeusinger deleted the claude/prompts-actions-unit-tests-01MX8oACHduSZes97NStyKHb branch November 30, 2025 17:23

Copilot finished reviewing on behalf of MarkusNeusinger November 30, 2025 17:26

Copilot AI reviewed Nov 30, 2025

View reviewed changes

MarkusNeusinger added a commit that referenced this pull request Dec 1, 2025

Integrate prompts and actions into unit tests (#69)

6c9148b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate prompts and actions into unit tests#69

Integrate prompts and actions into unit tests#69
MarkusNeusinger merged 3 commits intomainfrom
claude/prompts-actions-unit-tests-01MX8oACHduSZes97NStyKHb

MarkusNeusinger commented Nov 30, 2025

Uh oh!

codecov Bot commented Nov 30, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 30, 2025

Uh oh!

Copilot AI Nov 30, 2025

Uh oh!

Copilot AI Nov 30, 2025

Uh oh!

Copilot AI Nov 30, 2025

Uh oh!

Copilot AI Nov 30, 2025

Uh oh!

Copilot AI Nov 30, 2025

Uh oh!

Copilot AI Nov 30, 2025

Uh oh!

Copilot AI Nov 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		optimize_png(str(sample_image), str(output_path))

		assert output_path.exists()

	assert response.status_code in [200, 204, 400]
	assert response.status_code in [200, 204], f"Unexpected status: {response.status_code}"

	assert "_" in secret_name or len(secret_name) > 3, f"Secret name too short: {secret_name}"
	assert "_" in secret_name or len(secret_name) >= 6, f"Secret name too short or missing underscore: {secret_name}"

	assert len(overlap) >= 0, f"Workflow name unrelated to file: {filepath.name}"
	assert len(overlap) > 0, f"Workflow name unrelated to file: {filepath.name}"

Conversation

MarkusNeusinger commented Nov 30, 2025

Uh oh!

codecov Bot commented Nov 30, 2025

Codecov Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants