Add G10, G43, G49 to interpret existing G-code like LinuxCNC #27615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerAndere1
force-pushed
the
tool_length_compensation
branch
from
d5d7256 to
9d13224
Compare
DerAndere1
changed the title
DerAndere1
force-pushed
the
tool_length_compensation
branch
5 times, most recently
from
bab7ffb to
4467fdc
Compare
|
Thank you! This is exactly what I needed for using Marlin as CNC controller |
SL-RU
reviewed
Jan 23, 2025
DerAndere1
force-pushed
the
tool_length_compensation
branch
from
7c8acb2 to
0cb2516
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
4354891 to
efa1758
Compare
Contributor
Author
|
I tested some G10 commands on hardware. Working as expected. It's also future-proof: Even works as intended when I add code for 5 Axis kinematics and switch Tool Center Point Control on/off (G43.4/G49) |
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
3791e7d to
6ea4a16
Compare
DerAndere1
force-pushed
the
tool_length_compensation
branch
from
d69cf27 to
e4dd6d4
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
52532da to
06c6c47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requirements
Benefits
This is a prerequisite for multi axis kinematics, because G10, G43 and G49 in existing Gcode must be handled correctly for safety.
Configurations
See changes to default Configuration.h for an example that does not change behaviour.
For testing of G43/G49, enable
DEFAULT_TOOL_LENGTH_COMPENSATIONRelated Issues
#23688