Skip to content

Conversation

@classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Feb 24, 2025

Description

Note

may need to move some and split to another PR
but then again these are various fixes
Moved commenting/formatting to another PR

No real category to put these changes in, so here goes
Updates and fixes to various files:

  • SERIAL_STATS_DROPPED_RX is missing define. so it is added to config_adv.h
  • Add FLIP() to missed opportunity placement
  • Clear status msg in M104_M109 - [BUG] M109/M190 commands do not clear status message (REOPEN ISSUE) #27980
  • Remove ; typo from PlatformIO/scripts/STM32F1_create_variant.py done
  • Delete redundant share/scripts/languageUtil.py and moved contents into share/scripts/languageExport.py moved to Update Python scripts (mostly) #27752 (not planned)
  • Follow up to 🩹 Even more Z input shaper followup #27119, we have forgot to add ProUI definition for Input Shaping - ICON_ShapingZ
    • Added test option including Input Shaping X/Y/Z for ProUI in STM32F103RE_creality
  • Fixes errors and improve on code. for example: added import ... to prevent error of it missing in a .py file.
  • lcd/menu/menu_info.cpp: Fix buffer overflow warning increase msg buffer from 21 to 22, removed duplicate VALUE_ITEM_F

Taken from other PR (#27277)

  • Minimal fixes to spacing, comments
  • Update for better readability and proper usage
    • Changes like: #if HAS_LEVELING && HAS_ZOFFSET_ITEM) => #if ALL(HAS_LEVELING, HAS_ZOFFSET_ITEM)
  • Update e3v2 UI's
    • Combine HAS_DWIN_E3V2 into HAS_DISPLAY
    • Remove redundant HAS_UI_UPDATE
  • Rearrange some functions in marlinui.h - group into similar
  • M48.cpp - when using M48 test in ProUI, make screen 'pause' ("NothingToDo") (moved to ProUI ExtUI | EXTENSIBLE_UI, fixes & cleanup #26917)
  • Update CREALITY_V4 in pins.h to include RC board env type.

for printcounter.cpp would have to ask @thinkyhead


- Add FLIP() to missed opportunity placement, clear status message

in module/tempurature.cpp

- if ((do_buttons ^= true)) ui.update_buttons();6

+ if (FLIP(do_buttons)) ui.update_buttons();
 // If wait_for_heatup is set, temperature was reached, no cancel
      if (wait_for_heatup) {
... 
-       #else
          ui.reset_status();
-       #endif

 // If wait_for_heatup is set, temperature was reached, no cancel
      if (wait_for_heatup) {
... 
+       #endif
        ui.reset_status();

Requirements

Benefits

Configurations

Related Issues

@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 3 times, most recently from 4354891 to efa1758 Compare March 28, 2025 01:57
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 3 times, most recently from 52532da to 06c6c47 Compare November 20, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant