Skip to content

Conversation

@phixMe
Copy link
Member

@phixMe phixMe commented Oct 11, 2024

Problem

Our job node will now be colored appropriately as other places in the application.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
@boring-cyborg boring-cyborg bot added the web label Oct 11, 2024
@netlify
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 03a3d88
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6709582627cde10008895e10

@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (1022080) to head (03a3d88).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2922   +/-   ##
=========================================
  Coverage     82.21%   82.21%           
  Complexity     1504     1504           
=========================================
  Files           268      268           
  Lines          7253     7253           
  Branches        324      324           
=========================================
  Hits           5963     5963           
  Misses         1129     1129           
  Partials        161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc merged commit 24fab4b into main Oct 11, 2024
@wslulciuc wslulciuc deleted the feature/node-color branch October 11, 2024 17:02
@wslulciuc wslulciuc added this to the 0.50.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants