Skip to content

Add support to enable variable substitution with environment variables#82

Merged
wslulciuc merged 3 commits intomasterfrom
enable-variable-sub-with-env-vars
Sep 25, 2018
Merged

Add support to enable variable substitution with environment variables#82
wslulciuc merged 3 commits intomasterfrom
enable-variable-sub-with-env-vars

Conversation

@wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Sep 24, 2018

This PR now allows environment variable access from config.yml. For example:

database:
  driverClass: org.postgresql.Driver
  url: jdbc:postgresql://${POSTGRESQL_HOST:localhost}:${POSTGRESQL_PORT:5432}/${POSTGRESQL_DB_NAME}
  user: ${POSTGRESQL_USER}
  password: ${POSTGRESQL_PASSWORD}

A UndefinedEnvironmentVariableException is thrown when a variable defined in config.yml cannot be interpolated. An example error message might be:

The environment variable 'POSTGRESQL_PASSWORD' is not defined; could not substitute the expression '${POSTGRESQL_PASSWORD}'.

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #82 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
+ Coverage     60.62%   60.67%   +0.04%     
  Complexity      158      158              
============================================
  Files            40       40              
  Lines           795      796       +1     
  Branches         77       77              
============================================
+ Hits            482      483       +1     
  Misses          271      271              
  Partials         42       42
Impacted Files Coverage Δ Complexity Δ
src/main/java/marquez/MarquezApp.java 80.43% <100%> (+0.43%) 7 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176f041...327d146. Read the comment docs.

@wslulciuc wslulciuc force-pushed the enable-variable-sub-with-env-vars branch from 3f02fa1 to e7efd19 Compare September 25, 2018 04:00
@wslulciuc wslulciuc force-pushed the enable-variable-sub-with-env-vars branch from e7efd19 to 327d146 Compare September 25, 2018 17:55
@wslulciuc wslulciuc merged commit 6d4f0c3 into master Sep 25, 2018
@wslulciuc wslulciuc deleted the enable-variable-sub-with-env-vars branch September 25, 2018 18:06
@wslulciuc wslulciuc removed the ready label Oct 10, 2018
wslulciuc added a commit that referenced this pull request Nov 14, 2020
* Add input/output string support to JobMeta.Builder
wslulciuc pushed a commit that referenced this pull request Dec 3, 2020
* update client to service API v0.11.1

update this python client for the updated service api v0.11.1

* Update client.py

missing import

* update client

fixed max_length for all variables
added valid uuid check
created methods
refactored

* MarquezClient calls

create methods for reuse
qualify static methods with class name
update logic

* remove unused imports

fix typos
unused imports
fix verbage
wslulciuc added a commit that referenced this pull request Dec 11, 2020
Signed-off-by: wslulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants