Skip to content

todo zero commits

Jump to bottom Edit New page
cala edited this page Jan 23, 2013 · 43 revisions

stfx: Tthere are some classic-only related commits but all others which dont exist on master but would theoretically fit there need to be added on master first (if proper) ;)
cala : commented some of the commits.

  • zero 7746ed3 * Sidsukana (committer Sidsukana)
    [z1770] Fix spell Deep Wounds
  80.8% src/game/
  19.1% src/shared/

stfx: Correct fix, but shouldnt Deep Wounds code be in UnitAuraProcHandler.cpp as it is on master/tbc?

  • zero 5a5169b * Sidsukana (committer Sidsukana)
    [z1774] Fix speed modifiers for spells Permafrost, Improved Curse of Exhaustion, Camouflage, Pathfinding, Amplify Curse, Cheetah Sprint.
  95.8% src/game/
   4.1% src/shared/

[TEST] cala : Surprising one. I will also test it.

  • zero 1fa35f3 * TheLuda (committer TheLuda)
    Use the internal rank number for battleground statistics.
 100.0% src/game/

cala : Don’t see the purpose of this one. Is it still relevant after all the fixes made on TBC/WotLK and backported?
stfx: backports have probably nothing to do with all of the commits here. Really not sure what this should have fixed
cala: then maybe we should follow the wise rule “it it is broken, don’t fix it?”

  • zero c653a66 * Sidsukana (committer Sidsukana)
    [z1795] Fix take ammo for most ranged spells.
  97.4% src/game/

[TEST] stfx: not sure whats this about, should theoretically also apply to TBC but never heard of an issue there
cala : tested take ammo and found issue on current revision: ammo are not taken for all spells
(ex: ‘arcane shot’ does not take ammo but ‘serpent sting’ does). However, if no ammo in inventory no ranged spell can be casted, even those like ‘arcane shot’ that do not take ammo (though probably should take). I’ll try to test this commit.
stfx: was this behavior ever changed? it should be tested/fixed on tbc also if needed

  • zero e829694 * Sidsukana (committer Sidsukana)
    [z1796] Return diminishing to core. Limit duration in pre-BC was 15 sec.
  92.7% src/game/
   7.2% src/shared/

[REMOVE] cala: this one is wrong. According to * Diminishing return * and * Patch 1.4 * diminishing return does not reduce spell duration to 15 sec, instead When a spell with diminishing returns is used against a target in PvP, the first effect has full duration. On the second use of the same category of spell (e.g. slowing), that spell’s duration is reduced by 50%. On the third use, the duration is reduced by 75%. On the fourth attempt, the target becomes immune to the spell. Spells must be used on the same target within 15 seconds of the end of the duration in order to be diminished.

  • zero 4d68c37 * Salja (committer Salja)
    [z1798] Combustion (remove main aura) and (remove triggered aura stack) by Unlern Talents.
  91.2% src/game/
   8.7% src/shared/

[TEST] cala : Don’t sure this is needed. Will test it.

  • zero b7a8540 * Sidsukana (committer Sidsukana)
    [z1799] Remove extra mods code.
  87.7% src/game/extras/
   5.3% src/game/
   6.3% src/mangosd/

cala : see commit below

  • zero 139075f * TheLuda (committer TheLuda)
    [z1800] Remove all remains of TBC spell modifications.
  37.3% src/game/
  43.9% win/VC100/
  18.7% win/VC90/

cala : this one and the previous one are correct. In their current state, mods are needed for two purposes: TBC PvP diminishing returns (no need for classic) and modifying a paladin spell. This last one is moved into core by previous commit. So removing mods is safe but not mandatory.

  • zero 533c601 * Sidsukana (committer Sidsukana)
    Rever [z1801]
  96.3% src/game/
   3.6% src/shared/

[REMOVE] cala : should be trashed: this basically revert commit e829694 which was indeed wrong.

  • zero 205862d * Salja (committer Sidsukana)
    [z1803] Fix Nightfall with changes. Thx Salja.
  88.3% src/game/
  11.6% src/shared/

[TEST] cala : not sure about this one. Will test.

  • zero 7962b72 * Sidsukana (committer Sidsukana)
    [z1804] Fix CMSG_CHAT_IGNORED. Also fixed kick players if ignored player writing to them.
  66.8% src/game/
  33.1% src/shared/

[TEST] cala : I guess thi is no longer usefull with all the recent TBC backports. Will test it.
stfx: it might very well be useful as backports have nothing to do with it.

  • zero 482ca12 * Sidsukana (committer Sidsukana)
    [z1805] Fix Improved Sprint.
  76.2% src/game/
  23.7% src/shared/

[TEST] cala : This one looks ok but I will test it because I’m surprised it is not fixed in TBC also.

  • zero e0a0426 * Sidsukana (committer Sidsukana)
    [z1806] Fix HP change in bear forms.
  84.3% src/game/
  15.6% src/shared/

[TEST] cala : Seems ok but need to be tested. I’ll do it.

  • zero 84e3d1c * Sidsukana (committer Sidsukana)
    [z1807] Fix spell 6346.
  51.2% sql/updates/
  18.4% sql/
  30.2% src/shared/

[TEST] cala : This one is OK but this is only for DB. No need to backport to core. I’ll put it into DB if not already there.
stfx: There are some tables which are managed by mangos and not the database providers. this one is one of them.

  • zero a623e41 * Sidsukana (committer Sidsukana)
    [z1808] Fix talent Heart of the Wild. Actually for 1.12.x.
  66.2% src/game/
  33.7% src/shared/

[TEST] cala : this one should be ok. Heart of the Wild modifier for cat form were not cut by half before WotLK. Thus, this should also apply to TBC. I will test it nonetheless.

  • zero b2d8643 * Sidsukana (committer Sidsukana)
    [z1809] Fix item 23197.
  27.7% sql/updates/
  18.0% sql/
  29.3% src/game/
  24.8% src/shared/

[TEST] cala : need to be tested. I’ll do it.

  • zero 621a2de * Sidsukana (committer TheLuda)
    [z1824] Fix item 23197.
  40.2% sql/updates/
  23.9% sql/
  35.8% src/shared/

cala : Can be trashed: DB only update and already handled by previous commit.
stfx: There are some tables which are managed by mangos and not the database providers. this one is one of them.
cala: I did not know, my apologies :) . Yet this SQL query is already done in above commit b2d8643 and the sole result of this commit would be to alter db_version. This is why I advice to remove it.

  • zero f026561 * Cala Haryon (committer Cala Haryon)
    Modify the mana regeneration rate to be correct for 1.12 and below.
 100.0% src/game/

[OK] cala : this one is ok. See * Mana regenaration *

  • zero c041d59 * Cala Haryon (committer Cala Haryon)
    Fix glancing blows formula for zero.
 100.0% src/game/

[OK] cala : this one is ok. See * Glancing blow *

  • zero 06f5bb3 * Cala Haryon (committer Cala Haryon)
    Fix Druid Enrage Armor. Thanks to Salja
 100.0% src/game/

[TEST] cala : Spell id and armor reduction values are correct (see * rage generation – druid subsection *). Not sure about the aura id. However, Zakarumite stated that this spell is already in dbc and don’t need to be done in core. I’ll test it.

  • zero d09c299 * Cala Haryon (committer Cala Haryon)
    Fix Shaman Spell Rockbiter Weapon. Patch by Zataron, Thanks Salja
 100.0% src/game/

[REMOVE] cala : Even after this commit, I got issues from users saying this still not work as intented. Maybe we should trash this commit and fix the spell anew by opening an issue.

  • zero 6cffeff * Cala Haryon (committer Cala Haryon)
    Fix Sheeped/Feared Targets Bugging. Thanks Zataron & Salja
 100.0% src/game/

[TEST] cala : With all the recent backports from TBC to classic related to similar issues, I’m note sure this one is still needed. I will also test it.

  • zero 65baeed * Cala Haryon (committer Cala Haryon)
    Lower Stealth Detection of Creatures. Thanks Zataron & Salja
 100.0% src/game/

[TEST] cala : I will also test if this is still needed but I doubt it.

  • zero 22d7054 * Cala Haryon (committer Cala Haryon)
    Fix Aggro issues of Npc Summons. Thanks Zataron & Salja
 100.0% src/game/

[TEST] cala : With all the recents TBC backports about pets, this one should no longer be needed.
stfx: backports have probably nothing to do with it

  • zero f7debc1 * Cala Haryon (committer Cala Haryon)
    Fix Druid Attackpower in Cat and Bear Form. Patch by Zataron & Salja
 100.0% src/game/

[REMOVE] cala: Core currently use TBC values for druid AP (see * Attack Power as of April 18th 2008 *). However, I’m unable to find if they were different in classic. I guess so as feral druids got a big “up” in TBC but without correct 1.12 values, we should trash this commit and but put a note in StatSystem.cpp stating these values need to be confirmed.

  • zero e45f908 * Cala Haryon (committer Cala Haryon)
    Fix Beastslayer Damage Bonus. Thanks Zataron & Salja
 100.0% src/game/

[TEST] cala : Note sure this one is really needed. Silly me. I will test it.


FILE LAST UPDATED BASED ON… zero 9293a6d * TheLuda (committer TheLuda)

Add a custom footer
Add a custom sidebar

Clone this wiki locally