Conversation
- Reimported Loaf and Donut as well as added new animations
- Fixed a bug in the CameraRegisterVolume.cpp Tick function - Updated SCharacter.cpp to make character rotation relative to the current camera
GageM
added
enhancement
MashdorDev
reviewed
Feb 14, 2024
Owner
MashdorDev
left a comment
MashdorDev
left a comment
There was a problem hiding this comment.
Looks great just need the attention of @SafakOnol in the SCharacter.cpp
Owner
|
@GageM Don't forget to pull dev into the branch and push to the branch after you brought dev into your local branch |
Collaborator
Author
|
@MashdorDev Dev was pulled into the branch |
Collaborator
Author
|
That being said I can merge it again if you'd prefer |
Owner
|
I think you need to pull dev again after the #77 was pulled into dev so we don't have any conflicts |
Collaborator
Author
|
Alright, I just pulled Dev again and re-pushed |
Owner
|
Awesome, now we are just going to wait for @SafakOnol input on the code you asked him 👍 |
This was
linked to
issues
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has the character animation fixes as well as the spline-based camera