How to escape backslashes?

[kenkangxgwe]

Even though I thought this is a CMake/Ninja problem, since you have successfully built the ccls on Windows, it will be nice if you can help me around this.

This is my cmake command

cmake . -Brelease -G Ninja -DCMAKE_CXX_COMPILER=clang++ -DSYSTEM_CLANG=On -DCMAKE_PREFIX_PATH="D:\\Programs\\msys64\\mingw64\\lib\\clang\\6.0.0\\"
cmake --build release

I tried both / and \\ to split the path, but didn't help.

This caused the following errors:

[8/59] Building CXX object CMakeFiles/ccls.dir/src/main.cc.obj
FAILED: CMakeFiles/ccls.dir/src/main.cc.obj
D:\Programs\msys64\mingw64\bin\clang++.exe  -DDEFAULT_RESOURCE_DIRECTORY=\"D:\Programs\msys64\mingw64\lib\clang\6.0.0\" -DLOGURU_FILENAME_WIDTH=18 -DLOGURU_THREADNAME_WIDTH=13 -DLOGURU_WITH_STREAMS=1 -I../src -I../third_party -I../third_party/rapidjson/include -I../third_party/loguru -I../third_party/doctest -isystem D:/Programs/msys64/mingw64/include -O3 -DNDEBUG   -fno-rtti -Wall -Wno-sign-compare -std=c++1z -MD -MT CMakeFiles/ccls.dir/src/main.cc.obj -MF CMakeFiles\ccls.dir\src\main.cc.obj.d -o CMakeFiles/ccls.dir/src/main.cc.obj -c ../src/main.cc
../src/main.cc:70:3: error: use of undeclared identifier '_setmode'
  _setmode(_fileno(stdout), O_BINARY);
  ^
../src/main.cc:71:3: error: use of undeclared identifier '_setmode'
  _setmode(_fileno(stdin), O_BINARY);
  ^
2 errors generated.
[17/59] Building CXX object CMakeFiles/ccls.dir/src/indexer.cc.obj

Btw, what's the purpose of cmake -H. in the wiki?

[kenkangxgwe]

Or, maybe it is caused by my mingw64 version of Clang? I tried the following command but got the following error:

D:\Projects\ccls> cmake . -Brelease -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_COMPILER=clang++ -DSYSTEM_CLANG=O
ff -DCMAKE_PREFIX_PATH="D:/Programs/msys64/mingw64/lib/clang/6.0.0/"
-- The CXX compiler identification is Clang 6.0.0
-- Check for working CXX compiler: D:/Programs/msys64/mingw64/bin/clang++.exe
-- Check for working CXX compiler: D:/Programs/msys64/mingw64/bin/clang++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Using downloaded Clang
-- Downloading Clang 6.0.0 (https://releases.llvm.org/6.0.0/LLVM-6.0.0-win64.exe) ...
-- 7-Zip not found in PATH
-- Downloading 7-Zip 1801 (https://www.7-zip.org/a/7z1801-x64.msi) ...
-- Extracting downloaded 7-Zip ...
-- Extracting downloaded Clang with 7-Zip ...
CMake Error at D:/Programs/msys64/mingw64/share/cmake-3.11/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find Clang (missing: LLVM_INCLUDE_DIR LLVM_BUILD_INCLUDE_DIR)
  (found suitable version "6.0.0", minimum required is "6.0.0")
Call Stack (most recent call first):
  D:/Programs/msys64/mingw64/share/cmake-3.11/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindClang.cmake:116 (find_package_handle_standard_args)
  CMakeLists.txt:108 (find_package)

[MaskRay]

Pushed a commit to add #include <windows.h> but I'm not sure whether this is sufficient to support _setmode

[kenkangxgwe]

1. The _setmode problem is still there.

2. In build.ninja, it writes

DEFINES = -DDEFAULT_RESOURCE_DIRECTORY=\"D:\Programs\msys64\mingw64\lib\clang\6.0.0\"

And I get the following warnings:

[2/59] Building CXX object CMakeFiles/ccls.dir/src/utils.cc.obj
../src/utils.cc:155:10: warning: unknown escape sequence '\P' [-Wunknown-escape-sequence]
  return DEFAULT_RESOURCE_DIRECTORY;
         ^
<command line>:1:39: note: expanded from here
#define DEFAULT_RESOURCE_DIRECTORY "D:\Programs\msys64\mingw64\lib\clang\6.0.0"
                                      ^~
../src/utils.cc:155:10: warning: unknown escape sequence '\m' [-Wunknown-escape-sequence]
  return DEFAULT_RESOURCE_DIRECTORY;
         ^
<command line>:1:48: note: expanded from here
#define DEFAULT_RESOURCE_DIRECTORY "D:\Programs\msys64\mingw64\lib\clang\6.0.0"
                                               ^~
../src/utils.cc:155:10: warning: unknown escape sequence '\m' [-Wunknown-escape-sequence]
  return DEFAULT_RESOURCE_DIRECTORY;
         ^
<command line>:1:55: note: expanded from here
#define DEFAULT_RESOURCE_DIRECTORY "D:\Programs\msys64\mingw64\lib\clang\6.0.0"
                                                      ^~
../src/utils.cc:155:10: warning: unknown escape sequence '\l' [-Wunknown-escape-sequence]
  return DEFAULT_RESOURCE_DIRECTORY;
         ^
<command line>:1:63: note: expanded from here
#define DEFAULT_RESOURCE_DIRECTORY "D:\Programs\msys64\mingw64\lib\clang\6.0.0"
                                                              ^~
../src/utils.cc:155:10: warning: unknown escape sequence '\c' [-Wunknown-escape-sequence]
  return DEFAULT_RESOURCE_DIRECTORY;
         ^
<command line>:1:67: note: expanded from here
#define DEFAULT_RESOURCE_DIRECTORY "D:\Programs\msys64\mingw64\lib\clang\6.0.0"
                                                                  ^~
5 warnings generated.

3. I forget to mention that I manually added the following code to resolve the undefined O_BINARY problem:

#ifndef O_BINARY
#define O_BINARY 0
#endif

[MaskRay]

https://msdn.microsoft.com/en-us/library/tw4k6df8.aspx

[MaskRay]

_setmode is removed.

[MaskRay]

Can you try this change?

--- CMakeLists.txt
+++ CMakeLists.txt
-                           DEFAULT_RESOURCE_DIRECTORY="${Clang_RESOURCE_DIR}")
+                           DEFAULT_RESOURCE_DIRECTORY=R"(${Clang_RESOURCE_DIR})")

Sorry this does not work. I don't know how to make the cmake variable into a C++ raw string literal.

What's your output of -print-resource-dir?

% D:\Programs\msys64\mingw64\bin\clang++.exe -print-resource-dir
D:\Programs\msys64\mingw64\lib\clang\6.0.0
??

% D:/Programs/msys64/mingw64/bin/clang++.exe -print-resource-dir
??

[kenkangxgwe]

Here you are

[MaskRay]

What about D:/Programs/msys64/mingw64/bin/clang++.exe -print-resource-dir

[kenkangxgwe]

Same as above.

I figured if I use

DEFAULT_RESOURCE_DIRECTORY=R"\(${Clang_RESOURCE_DIR}\)")

the command changes to:

PS D:\Projects\ccls> cmake --build release
[8/37] Building CXX object CMakeFiles/ccls.dir/src/main.cc.obj
FAILED: CMakeFiles/ccls.dir/src/main.cc.obj
D:\Programs\msys64\mingw64\bin\clang++.exe  -DDEFAULT_RESOURCE_DIRECTORY=R\"(D:\Programs\msys64\mingw64\lib\clang\6.0.0)\" -DLOGURU_FILENAME_WIDTH=18 -DLOGURU_THREADNAME_WIDTH=13 -DLOGURU_WITH_STREAMS=1 -I../src -I../third_party -I../third_party/rapidjson/include -I../third_party/loguru -I../third_party/doctest -isystem D:/Programs/msys64/mingw64/include -O3 -DNDEBUG   -fno-rtti -Wall -Wno-sign-compare -std=c++1z -MD -MT CMakeFiles/ccls.dir/src/main.cc.obj -MF CMakeFiles\ccls.dir\src\main.cc.obj.d -o CMakeFiles/ccls.dir/src/main.cc.obj -c ../src/main.cc
../src/main.cc:72:3: error: use of undeclared identifier '_setmode'
  _setmode(_fileno(stdout), O_BINARY);
  ^
../src/main.cc:73:3: error: use of undeclared identifier '_setmode'
  _setmode(_fileno(stdin), O_BINARY);
  ^
2 errors generated.
[17/37] Building CXX object CMakeFiles/ccls.dir/src/messages/text_document_completion.cc.obj
ninja: build stopped: subcommand failed.

but the _setmode is still not resovled

[MaskRay]

I made a force push yesterday. _setmode has been changed to ChangeStdinToBinary

[MaskRay]

I have also commented that _setmode is removed..
I asked what's the output of clang -print-resource-dir if forward slashes are used.

[kenkangxgwe]

Thanks for your commit. The original error is not there anymore.

Please see #22 (comment) I replied yesterday for the output of both backslashed and slashed clang -print-resource-dir.

Currently, my workaround is to use the raw string:
DEFAULT_RESOURCE_DIRECTORY=R"\(${Clang_RESOURCE_DIR}\)")

I will close this issue, thank you.

[MaskRay]

This has been fixed by #73