Fix: Add public initializers for SavedFeed and SavedFeedPreferencesVe…#200
Merged
MasterJ93 merged 1 commit intoMasterJ93:mainfrom Jul 23, 2025
Merged
Fix: Add public initializers for SavedFeed and SavedFeedPreferencesVe…#200MasterJ93 merged 1 commit intoMasterJ93:mainfrom
MasterJ93 merged 1 commit intoMasterJ93:mainfrom
Conversation
MasterJ93
approved these changes
Jul 23, 2025
Owner
|
Thanks for the PR. I'll go ahead and merge it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When working with saved feeds preferences, it's currently impossible to create instances of
SavedFeedandSavedFeedPreferencesVersion2Definitionwithout using JSON serialization workarounds. These structs only haveDecodableinitializers, which makes programmatic creation unnecessarily complex.Solution
This PR adds public initializers for:
AppBskyLexicon.Actor.SavedFeedAppBskyLexicon.Actor.SavedFeedPreferencesVersion2DefinitionChanges
Added public initializers following ATProtoKit's strict guidelines:
Testing
The initializers have been tested to ensure they create objects identical to those decoded from JSON responses.
Example Usage