Improve http response error catch#10
Merged
Merged
Conversation
- Improve http response error catch
Member
Author
|
hi @mattfarina |
Member
|
@franciscocpg Sorry for the slow response. I have been out most of the past several months and am behind. I'll take a look at this one soon. |
Member
|
I merged master in and fixed the issue and then manually merged this change in. Thanks. The added clarity will be helpful. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has an improvement about catching http errors also adding some verbosity to output.
Related (but not a solution) to Masterminds/glide#639.