Skip to content

[bugfix] Audio is not a block tag #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goetas merged 1 commit into from
Oct 22, 2018
Merged

[bugfix] Audio is not a block tag #142

goetas merged 1 commit into from
Oct 22, 2018

Conversation

@goetas
Copy link
Member

@goetas goetas commented Oct 8, 2018 •
edited
Loading

fixes #121

see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/audio

The default controls have a display value of inline by default, and it is often a good idea set the value to block to improve control over positioning and layout, unless you want it to sit within a text block or similar.

@goetas goetas mentioned this pull request Oct 8, 2018
Closed
@goetas goetas added the bug label Oct 8, 2018
@goetas goetas merged commit 7c25685 into 2.x Oct 22, 2018
@goetas goetas deleted the audio-tag branch November 23, 2018 06:48
esperecyan added a commit to esperecyan/html-filter that referenced this pull request Jan 25, 2020
@esperecyan
audioがフレーシングとして扱われない不具合が Masterminds/html5-php#142 で修正されたため、videoのみ対処へ
edf8a0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goetas