-
-
Notifications
You must be signed in to change notification settings - Fork 0
Introducing AsSimplifiedExpression() Requirement to Expression Interface #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it to fix some of the substitute methods for Polynomials
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 87.44% 87.46% +0.02%
==========================================
Files 42 42
Lines 6332 6431 +99
==========================================
+ Hits 5537 5625 +88
Misses 719 719
- Partials 76 87 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On the course to fixing a bug in MatProGo-dev/simplex, we realized that there was a problem with
(p Polynomial) Substitute. The issue was shared with other polynomial objects.We began to find that the issue could be helped by introducing a proper Simplification method to all expressions to avoid some issues of complicated conversions in the
Polynomialmethods.Introduced the
AsSimplifiedExpression()method to theExpression(and related) interfaces. This should make it much easier (thoughtless really) to simplify.