Skip to content

Conversation

@kwesiRutledge
Copy link
Collaborator

Summary

On the course to fixing a bug in MatProGo-dev/simplex, we realized that there was a problem with (p Polynomial) Substitute. The issue was shared with other polynomial objects.

We began to find that the issue could be helped by introducing a proper Simplification method to all expressions to avoid some issues of complicated conversions in the Polynomial methods.

Introduced the AsSimplifiedExpression() method to the Expression (and related) interfaces. This should make it much easier (thoughtless really) to simplify.

@kwesiRutledge kwesiRutledge self-assigned this Sep 30, 2025
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 77.38095% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.46%. Comparing base (9adff8d) to head (82f7c6a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
symbolic/monomial_matrix.go 75.67% 7 Missing and 2 partials ⚠️
symbolic/matrix_expression.go 80.48% 7 Missing and 1 partial ⚠️
symbolic/polynomial_vector.go 56.25% 6 Missing and 1 partial ⚠️
symbolic/constant.go 0.00% 2 Missing ⚠️
symbolic/constant_matrix.go 66.66% 2 Missing ⚠️
symbolic/monomial_vector.go 84.61% 1 Missing and 1 partial ⚠️
symbolic/polynomial_matrix.go 85.71% 1 Missing and 1 partial ⚠️
symbolic/variable.go 0.00% 2 Missing ⚠️
symbolic/variable_matrix.go 50.00% 2 Missing ⚠️
symbolic/variable_vector.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   87.44%   87.46%   +0.02%     
==========================================
  Files          42       42              
  Lines        6332     6431      +99     
==========================================
+ Hits         5537     5625      +88     
  Misses        719      719              
- Partials       76       87      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kwesiRutledge kwesiRutledge merged commit 8f261a9 into main Oct 3, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants