Update PyPI versioning in CI workflow#8
Merged
Conversation
Maturin reads the version from pyproject.toml and the workspace Cargo.toml. Without updating these files the built wheel always carries the placeholder version (0.0.1) and the upload to PyPI fails with '400 File already exists'. Add an 'Update release version' step (shell: bash for cross-platform compatibility) to both build-wheels and build-sdist jobs that patches: - tp-py/pyproject.toml [project] version - Cargo.toml workspace version (inherited via version.workspace) - tp-py/Cargo.toml tp-lib-core path-dependency version pin This mirrors the approach already used in publish-crates.yml. The NuGet workflow already handles versioning correctly via -p:PackageVersion and required no changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the CI workflow to update the PyPI version from the Git tag before building. This change prevents the upload failure due to placeholder versions and ensures correct versioning in the built artifacts.