-
Notifications
You must be signed in to change notification settings - Fork 24
Improve cross compilation support for vendored sasl2 builds #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improve cross compilation support for vendored sasl2 builds #55
Conversation
By using autotools to configure sasl2, we gain support for cross compilation because the tool chain is automatically retrieved from CC_<target triplet>.
|
Hi @tillrohrmann, thanks for the patch. A few notes though:
|
|
Thanks a lot for getting back to me so quickly @benesch 🙏
The problem I am seeing when cross compiling from arm64 to amd64 is: This looks as if the libsasl2_sys artifacts are built with the wrong architecture. Note that I am running in an environment with With the autotools fix, this problem is gone. I also noticed that you are deriving the
You are right that systest is not needed when only depending on |
6298ec4 to
d3e87c5
Compare
When cross compiling we cannot run tests. Hence, setting ac_cv_gssapi_supports_spnego to yes to disable them.
|
I've pushed an additional commit which disables tests when cross compiling to improve the user experience. |
This PR introduces autotools into the sasl2-sys/build.rs to automatically derive the correct toolchain based on
HOSTandTARGETfromCC_<target triplet>,CXX_<target triplet>,AR_<target triplet>.Additionally, it makes cross compilation possible by not runningsystestif we are cross compiling.This fixes #54