Skip to content

Conversation

@gpetretto
Copy link
Contributor

PBS returns an exit_code != 0 even if the execution of the qstat command is partially succeeded while getting the information for a list of jobs. For this reason we did not raise based on exit_code. With this PR the parse_jobs_list_output in PBSIO will start raising if exit_code is not 0 and selected messages are not present in stderr.

Hopefully this may help addressing Matgenix/jobflow-remote#403

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.48%. Comparing base (53e06b0) to head (4b86e2e).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/qtoolkit/io/pbs.py 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #57      +/-   ##
===========================================
- Coverage    99.70%   99.48%   -0.23%     
===========================================
  Files           17       17              
  Lines         1350     1353       +3     
  Branches       188      189       +1     
===========================================
  Hits          1346     1346              
- Misses           2        4       +2     
- Partials         2        3       +1     
Files with missing lines Coverage Δ
src/qtoolkit/io/pbs.py 97.54% <25.00%> (-2.46%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me. You can add the test I sent you maybe ? Also maybe you can add python 3.14 in the tests and remove 3.9 in this same PR or you'd do it in a separate one ?

@gpetretto
Copy link
Contributor Author

All good to me. You can add the test I sent you maybe ? Also maybe you can add python 3.14 in the tests and remove 3.9 in this same PR or you'd do it in a separate one ?

I have already started adding the option to select the containers for the integration tests in another branch. If you don't mind I will merge as is and add your integration test in another PR.

@gpetretto gpetretto merged commit 3bc1180 into develop Nov 18, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants