Problem
OpenGALib/Riemannian/Util/ contains two confusingly-named neighbors:
ChartJacobianSmooth.lean — smoothness of CLM-valued composites (operator level)ChartJacobianSmoothness.lean — smoothness of scalar matrix entries
They are NOT duplicates, but the names differ only by the suffix "ness" and don't signal the actual abstraction-level difference (CLM vs scalar). A reader has to open both to disambiguate.
Proposal
Rename to spell out the level:
| Old |
New |
ChartJacobianSmooth.lean |
ChartJacobianCLM.lean or ChartJacobianOperators.lean |
ChartJacobianSmoothness.lean |
ChartJacobianEntries.lean or ChartJacobianMatrixEntries.lean |
Final names TBD; the requirement is that they signal the abstraction level (CLM-valued vs scalar entry) without overlap.
Cascade
import path changes across consumers. Probably ~5-10 sites. Mechanical.
Acceptance
- Build clean
- File-level docstrings updated to match new name
Riemannian/Util/README.md table updated
Related
May want to combine with #5 (Util reorg) since both move into Util/Chart/ together.
Problem
OpenGALib/Riemannian/Util/contains two confusingly-named neighbors:ChartJacobianSmooth.lean— smoothness of CLM-valued composites (operator level)ChartJacobianSmoothness.lean— smoothness of scalar matrix entriesThey are NOT duplicates, but the names differ only by the suffix "ness" and don't signal the actual abstraction-level difference (CLM vs scalar). A reader has to open both to disambiguate.
Proposal
Rename to spell out the level:
ChartJacobianSmooth.leanChartJacobianCLM.leanorChartJacobianOperators.leanChartJacobianSmoothness.leanChartJacobianEntries.leanorChartJacobianMatrixEntries.leanFinal names TBD; the requirement is that they signal the abstraction level (CLM-valued vs scalar entry) without overlap.
Cascade
importpath changes across consumers. Probably ~5-10 sites. Mechanical.Acceptance
Riemannian/Util/README.mdtable updatedRelated
May want to combine with #5 (Util reorg) since both move into
Util/Chart/together.