<fix>[ha]:nmap disable arp ping

[zstack-robot-1]

Resolves: ZSTAC-59234

Change-Id: I7278616375686c7664656f7865637a786a76676e
(cherry picked from commit d01f9e2)

sync from gitlab !4509

Summary by CodeRabbit

• 新功能
  • 改进了主机扫描的可靠性。

[coderabbitai]

Walkthrough

本次更新主要涉及ha_plugin.py文件中scan_host方法的改进。为了提升宿主机扫描的可靠性，我们在使用nmap命令时增加了--disable-arp-ping选项。这一改动有助于在某些网络环境下更准确地发现宿主机。

Changes

文件路径	更改摘要
kvmagent/kvmagent/plugins/ha_plugin.py	scan_host方法中的nmap命令新增--disable-arp-ping选项，以提高扫描可靠性。

🐰✨

在代码的田野上，小兔跳跃，更新来了，

nmap指令轻轻变，探测更准，不再迷茫。

网络的海洋，波涛汹涌，我们航行，

用心聆听，静候每一个响应，

小小改变，带来大大希望。🌟

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 5f59a74 and 14edad5.

Files selected for processing (1)

• kvmagent/kvmagent/plugins/ha_plugin.py (2 hunks)

Additional comments: 3

kvmagent/kvmagent/plugins/ha_plugin.py (3)

• 908-908: 在 scan_host 方法中添加了 --disable-arp-ping 选项到 nmap 命令中，以提高主机扫描的可靠性。这是一个针对特定网络环境的优化，其中 ARP ping 可能不可靠或被过滤。请确保这一更改在所有预期的网络环境中都经过了充分的测试，以避免意外的副作用。
• 924-924: 在 scan_host 方法中再次添加了 --disable-arp-ping 选项到 nmap 命令中。这一更改与之前的相同，用于在不稳定连接的情况下再次尝试扫描。同样，请确保这一更改在所有预期的网络环境中都经过了充分的测试。
• 905-911: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-1024]

整个文件中，除了添加 --disable-arp-ping 选项外，没有标注其他具体的更改。请确保这一更改不会意外影响到文件中的其他功能，特别是那些与网络和存储操作相关的功能。此外，考虑到高可用性功能的复杂性，建议对相关的错误处理和报告机制进行彻底的测试，以确保系统的稳定性和可靠性。