Skip to content

<fix>[compute]: merge dataDisk parameters in CreateVmInstanceMsg#2014

Closed
zstack-robot-2 wants to merge 18 commits intozsv_4.10.10from
sync/wenhao.zhang/zsv-6@@2
Closed

<fix>[compute]: merge dataDisk parameters in CreateVmInstanceMsg#2014
zstack-robot-2 wants to merge 18 commits intozsv_4.10.10from
sync/wenhao.zhang/zsv-6@@2

Conversation

@zstack-robot-2
Copy link
Copy Markdown
Collaborator

merge CreateVmInstanceMsg.dataDiskOfferingUuid to
diskAOs[1..].diskOfferingUuid

merge CreateVmInstanceMsg.dataDiskSize to
diskAOs[1..].size

Resolves: ZSV-8585

Change-Id: I6e656a636f7176756566736f696d617769707570

sync from gitlab !7746

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2025

Walkthrough

本次更改包括将版本号从 10 增加到 13,并新增了一个数据库升级脚本。该脚本会为与模板化虚拟机相关的 VM HA 表记录,设置 inhibitionReason 和 inhibitionTime 字段。

Changes

文件/路径 变更摘要
VERSION 版本号从 10 增加到 13
conf/db/upgrade/V4.10.11__schema.sql 新增数据库升级脚本,更新 VmHaVO 表相关字段

Poem

小兔挥爪点数字,
版本轻跃到十三,
模板虚机记原因,
时间印记不再疑。
数据库也换新衣,
一切井然又有序!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e0be54 and d6d2768.

📒 Files selected for processing (2)
  • VERSION (1 hunks)
  • conf/db/upgrade/V4.10.11__schema.sql (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • VERSION
  • conf/db/upgrade/V4.10.11__schema.sql

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MatheMatrix MatheMatrix force-pushed the sync/wenhao.zhang/zsv-6@@2 branch 4 times, most recently from 20e2080 to 8e0be54 Compare April 17, 2025 08:22
Zhang Wenhao and others added 18 commits May 6, 2025 18:00
Resolves: ZSV-8729
Related: ZSV-8717
Related: ZSV-7433

DBImpact

Change-Id: I67716671686274657a78767678766a696b6b6765
(cherry picked from commit a34f87b)
<fix>[conf]: prevent VM template from starting

See merge request zstackio/zstack!7790
Resolves: ZSV-8736

Change-Id: I6f616a7a656e6b7164667565666e786e666c6f73
<fix>[root]: bump version to 4.10.11

See merge request zstackio/zstack!7798
fix flatten volume failed on sblk because cannot getting backing file of top.

Resolves: ZSTAC-74092
Resolves: ZSV-8771

Change-Id: I656c63786e6a766b676964686e6e61636661617a
…igration

trash volume snapshots after storage live migration

Resolves: ZSTAC-59025

Change-Id:4F45D1D0E51344889562D1A5761B626


(cherry picked from commit 6a76fa6)
when root node snapshot in reference tree
deleted from DB, reference will be reserved for track.
so this check must be removed.

Resolves: ZSTAC-64090
Resolves: ZSV-8774

Change-Id: I627665757a6d756c6c6774766469786f7068626f
<fix>[volumeSnapshot]: fix flatten volume failed on sblk

See merge request zstackio/zstack!7802
<fix>[storage-migration]: trash volume snapshots after storage live migration

See merge request zstackio/zstack!7809
Resolves: ZSV-8436

Change-Id: I6d726f636d777167676b6b6575706d6d756f7661
<fix>[kvm]: fix the description for failed sensor information retrieval

See merge request zstackio/zstack!7820
Resolves: ZSV-8978

Change-Id: I62716763766b696461636c70746f786579666871
<fix>[root]: bump version to 4.10.12

See merge request zstackio/zstack!7872
Resolves: ZSV-9045

Change-Id: I6271626975786675736b727268697a7979687970
<fix>[root]: bump version to 4.10.13

See merge request zstackio/zstack!7918
Ping ZCE-X path update to "/api/v1/cluster/time"

Resolves: ZSV-8959
Related: ZSV-7444

Change-Id: I6e7979776a677062727071717465626674746768
(cherry picked from commit 18216a4)
<fix>[sdk]: ping ZCE-X by new url path

See merge request zstackio/zstack!7939
Resolves: ZSV-9068
Related: ZSV-9044

APIImpact

Change-Id: I7a67746b68656f6a747269776167676f6b687874
(cherry picked from commit 86dc9ad)
@MatheMatrix MatheMatrix force-pushed the sync/wenhao.zhang/zsv-6@@2 branch from 8e0be54 to d6d2768 Compare June 18, 2025 07:34
@ZStack-Robot ZStack-Robot deleted the sync/wenhao.zhang/zsv-6@@2 branch June 19, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants