Shorten TraceEvaluation #1486
Merged
Shorten TraceEvaluation #1486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of the form: Replacing: x -> x don't add anything, so remove them. In the future, maybe we can have a "verbosity level" to include something like this. The only purpose I can see, is to indicate that a rewrite rule was considered and did nothing. However, TraceEvaluations are typically very long and in my experience doesn't add clarity, just clutter.
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lines of the form:
Replacing: x -> x
don't add much, so remove them.
In the future, we may consider introducing a "verbosity level" to accommodate features like this. The only purpose I can see is to indicate that a rewrite rule was considered and did nothing. Note that the same thing is indicated on a subsequent Return, which we still keep.
TraceEvaluations are typically very long and, in my experience, don't add clarity, just clutter.