Skip to content

fix: added readableChunkSize parameter to config and defaulted the … #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: added readableChunkSize parameter to config and defaulted the … #84

merged 1 commit into from
Feb 6, 2024

Conversation

@tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Jan 31, 2024 •
edited
Loading

Description

This PR addresses the excessive memory used by each QUICStream by providing a readableChunkSize config parameter and using that as the size when allocating the Buffer. This is defaulted to 4KB which is much less than the 1MB that was used before.

Issues Fixed

Tasks

  • 1. Add config option for setting the amount of memory used for the readable buffer.
  • 2. reduce the amount reserved memory to the kilobyte range for each QUICStream.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes
fix: added readableChunkSize parameter to config and defaulted the …
51cdc5f 
…readable buffer to 4kb

* Related: #83

[ci skip]
@tegefaulkes tegefaulkes self-assigned this Jan 31, 2024
@ghost
Copy link

ghost commented Jan 31, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tegefaulkes tegefaulkes merged commit 63e7c41 into staging Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tegefaulkes tegefaulkes

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce read buffer size for QUICStream

2 participants

@tegefaulkes