fix: Return all intersecting ABIs instead of just one #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original logic had a critical bug: even when multiple ABIs were in the intersection, it would only return a single ABI based on priority (arm64 > x86_64 > first). This caused APKs to only contain one architecture's native libraries, leading to 'library not found' errors on other architectures. Changes: - Return all intersecting ABIs instead of selecting one - Add disableAbiOptimization option for full control - Properly pass extension parameter to resolveAbiList This maintains IDE optimization (only build what's needed for deployment) while ensuring all necessary architectures are built. Fixes: #3
Owner
|
@xz-dev, thank you for your contributions. these changes were very good. Both of your pull requests have been included in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original logic had a critical bug: even when multiple ABIs were in the intersection, it would only return a single ABI based on priority (arm64 > x86_64 > first). This caused APKs to only contain one architecture's native libraries, leading to 'library not found' errors on other architectures.
Changes:
This maintains IDE optimization (only build what's needed for deployment) while ensuring all necessary architectures are built.
Fixes: #3