Closed
Conversation
Contributor
Author
|
I think we should allow users to be able to change the default clear color and every color in the editor theme color set to any color they want. This will mean adding ~17 new options to settings so these could probably be moved to their own tab. Not sure if users should be able to edit existing color theme presets like light and dark. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All I did was duplicate the dark theme and changed the default clear color from
4d4d4dto000000. On second thought maybe we do not need to add a whole extra theme just to do this. Could just expose the default clear color as an option in the settings.I'm still experimenting with this so I'm not entirely sure what the best option is.