Introduce new messages config#1
Merged
Merged
Conversation
…ty and consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
MessagesConfigconfiguration class to centralize all user-facing messages and error strings, replacing hardcoded messages throughout the codebase. This change increases maintainability and makes it easier to customize messages without modifying code. The update also refactors command logic to use these configurable messages and cleans up the previous approach of storing error messages inMainConfig.Centralized Message Configuration
MessagesConfigclass that holds all success and error messages, and integrated it into the configuration manager (CobbledLevelControlConfigManager). [1] [2] [3] [4] [5]errorMessagessection fromMainConfig, consolidating all message strings into the new config. [1] [2]Command Logic Refactoring
LevelControlCommand.javato use messages fromMessagesConfiginstead of hardcoded strings, improving consistency and enabling easier localization or customization. [1] [2] [3] [4] [5] [6]Consistency and Bug Fixes
RuntimeDifficulty.emptyDifficultyinstead of the string"none", ensuring consistent logic throughout event listeners and commands. [1] [2] [3]These changes make the codebase easier to maintain and extend, especially for users who want to customize in-game messages.