Enhance capture cancellation handling and logging in CaptureListener#6
Merged
Conversation
… logging and battle state management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and logging of canceled Pokémon capture events during battles in the
CaptureListenerclass. The main changes add detailed logging, ensure proper cleanup when a capture is canceled mid-battle, and send the correct network packet to notify the client.Key improvements to capture cancellation during battles:
BattleCaptureEndPacketto notify the client that the capture has ended. [1] [2]finishCaptureActionto properly clean up the capture action in the battle.These changes make the capture cancellation process more robust and transparent, especially in the context of ongoing battles.