This repository was archived by the owner on Jan 22, 2026. It is now read-only.
[pull] master from angular:master#131
Merged
pull[bot] merged 13 commits intoMattlk13:masterfrom Feb 6, 2020
Merged
Conversation
…34792) This commit moves the calculation of `ignoreFiles` - the set of files to be ignored by a consumer of the `NgCompiler` API - from its `prepareEmit` operation to its initialization. It's now available as a field on `NgCompiler`. This will allow a consumer to skip gathering diagnostics for `ignoreFiles` as well as skip emit. PR Close #34792
#34792) This commit implements an experimental integration with tsc_wrapped, where it can load the Angular compiler as a plugin and perform Angular transpilation at a user's request. This is an alternative to the current ngc_wrapped mechanism, which is a fork of tsc_wrapped from several years ago. tsc_wrapped has improved significantly since then, and this feature will allow Angular to benefit from those improvements. Currently the plugin API between tsc_wrapped and the Angular compiler is a work in progress, so NgTscPlugin does not yet implement any interfaces from @bazel/typescript (the home of tsc_wrapped). Instead, an interface is defined locally to guide this standardization. PR Close #34792
Previously we needed the `components-repo-ci` blocklist to disable tests that were failing during the development of Ivy. Since we fixed all those failing tests, and we don't want to regress, we can remove the blocklist logic. Resolves FW-1807 PR Close #35115
`additional_root_paths` should contain the workspace name see: https://github.com/bazelbuild/rules_nodejs/blob/d4200191c5fb84f395311840d8f90d3715e9f751/packages/typescript/src/internal/devserver/ts_devserver.bzl#L137-L140 Fixes #35144 PR Close #35159
Currently the prod server uses a default port of 8080, with this change we align the port with the devserver. PR Close #35160
In the past we had connecitivity issues on Saucelabs. Browsers on mobile devices were not able to properly resolve the `localhost` hostname through the tunnel. This is because the device resolves `localhost` or `127.0.0.1` to the actual Saucelabs device, while it should resolve to the tunnel host machine (in our case the CircleCI VM). In the past, we simply disabled the failing devices and re-enabled the devices later. At this point, the Saucelabs team claimed that the connecitivy/proxy issues were fixed. Saucelabs seems to have a process for VMs which ensures that requests to `localhost` / `127.0.0.1` are properly resolved through the tunnel. This process is not very reliable and can cause tests to fail. Related issues have been observed/mentioned in the Saucelabs support docs. e.g. https://support.saucelabs.com/hc/en-us/articles/115002212447-Unable-to-Reach-Application-on-localhost-for-Tests-Run-on-Safari-8-and-9-and-Edge https://support.saucelabs.com/hc/en-us/articles/225106887-Safari-and-Internet-Explorer-Won-t-Load-Website-When-Using-Sauce-Connect-on-Localhost In order to ensure that requests are always resolved through the tunnel, we add our own domain alias in the CircleCI's hosts file, and enforce that it is always resolved through the tunnel (using the `--tunnel-domains` SC flag). Saucelabs devices by default will never resolve this domain/hostname to the actual local Saucelabs device. PR Close #35171
We fixed the tunnel connectivity issues by using a localhost domain alias. Hence we can re-enable the Android 7.1 Saucelabs tests. PR Close #35171
) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](angular/cli-builds@94d0790...d452f08): **Modified** - help/generate.json ## PR Close #35185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )