fix: Container OS reported instead of Host OS #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the case when the host os uses /usr/lib/os-release Handle the case when the os-release file is a symlink (need to constantly retarget into /mnt/host/)
Now checks if already in /mnt/host before prepending Also pepper in debug statements to troubleshoot
Owner
|
Hey there, thanks for the contribution! I will try to review it on the weekend! |
Contributor
Author
|
I'm happy to clean things up or make changes if you'd like in particular the behavior changes:
I would love to see this merge since it bothers me on my server. |
Owner
|
Just reviewed it and looks good to me! Will try to push out a new release as soon as possible. Thanks! |
github-actions bot
added a commit
that referenced
this pull request
Aug 10, 2025
# [6.2.0](v6.1.0...v6.2.0) (2025-08-10) ### Bug Fixes * auto sizing for chart not working on load ([6b88601](6b88601)) * **docs:** update configuration url in readme ([#1227](#1227)) ([1941c26](1941c26)), closes [#1091](#1091) [#1168](#1168) [#1212](#1212) * report host os instead of container os ([#1233](#1233)) ([508c832](508c832)), closes [#1232](#1232) ### Features * added sub/root/base path routing ([#1229](#1229)) ([70c26d0](70c26d0))
Contributor
|
🎉 This issue has been resolved in version 6.2.0 Please check the changelog for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows absolute symlinks recursively in order to properly display
os-release, even in environments such as NixOS which use absolute symlinks for/etc/os-release.It also checks manually for
/mnt/host/etc/os-releaseand/mnt/host/usr/lib/os-releasein case a distro did not create/etc/os-releaseas a link at all to/usr/lib/os-release.Related Issue(s)
#1232