Skip to content

Pin dirty page buffers and bump version to 1.1.0#3

Open
MaxAkbar wants to merge 4 commits intomainfrom
Improve_CSharpDB_Storage
Open

Pin dirty page buffers and bump version to 1.1.0#3
MaxAkbar wants to merge 4 commits intomainfrom
Improve_CSharpDB_Storage

Conversation

@MaxAkbar
Copy link
Owner

@MaxAkbar MaxAkbar commented Mar 4, 2026

Summary

  • Keep dirty page data pinned in PageBufferManager so dirty buffers survive cache eviction before commit.
  • Update TryGetDirtyPage to prefer pinned dirty buffers and then fall back to cache.
  • Clear pinned dirty buffers when dirty/all state is cleared.
  • Bump package version in Directory.Build.props from 1.0.0 to 1.1.0.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactor / maintenance
  • Tests only

Related Issues

  • None linked.

Testing

  • dotnet build CSharpDB.slnx
  • Relevant tests executed
  • Manual verification performed (if applicable)

Checklist

  • I followed the project style and conventions.
  • I added or updated tests for behavior changes.
  • I updated docs for user-facing changes.
  • I verified no sensitive data was added.

Notes for Reviewers

  • This change introduces _dirtyBuffers to preserve mutable dirty pages independent of cache eviction policy.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 726b28b743

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant