Skip to content

Phase 3: Move entity resolution out of classifier#75

Merged
MaxLinCode merged 1 commit intomainfrom
claude/phase3-pipeline
Apr 1, 2026
Merged

Phase 3: Move entity resolution out of classifier#75
MaxLinCode merged 1 commit intomainfrom
claude/phase3-pipeline

Conversation

@MaxLinCode
Copy link
Copy Markdown
Owner

@MaxLinCode MaxLinCode commented Apr 1, 2026

Summary

  • Strip resolvedEntityIds and resolvedProposalId from TurnClassifierOutput — classifier now returns { turnType, confidence } only
  • Add resolveWriteTarget() to turn-router.ts to derive entity/proposal targets from discourse state and entity registry, post-classification
  • Pass targetEntityId and resolvedProposalId as explicit params into decideTurnPolicy and proposal-rules instead of reading from classifier output

Test Plan

  • All 262 tests pass (pnpm --filter @atlas/core test + pnpm --filter @atlas/web test)
  • Typecheck clean (pnpm --filter @atlas/core typecheck + pnpm --filter @atlas/web typecheck)
  • resolveWriteTarget unit tests cover: discourse state deduplication, confirmation+proposal override, empty state, non-confirmation with single proposal

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
atlas-web Ignored Ignored Apr 1, 2026 6:11pm

@MaxLinCode MaxLinCode merged commit a482353 into main Apr 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant