Fix blank intervals.icu OAuth login page, add structured error logging across all network/BLE calls, and document log file locations by Copilot · Pull Request #116 · MaximumTrainer/MaximumTrainer_Redux

Copilot · 2026-04-04T09:08:14Z

DialogInfoWebView::pageLoaded(ok=false) was a silent no-op — when the OAuth page failed to load, the user saw a blank white dialog with no feedback and nothing in any log. Alongside this, the entire codebase used qDebug()/qWarning() in network and BLE error paths, which are suppressed by the default Info log level and never reach the log file.

Blank login page fix

dialoginfowebview.cpp/.h

pageLoaded(false) now renders a user-friendly error page via buildErrorPageHtml() (extracted as a private const helper):
- shows the failed URL with a copy-paste <pre> block
- "open in browser" link as a fallback
- log file path so the user knows where to look
m_showingErrorPage guard prevents the injected HTML from re-triggering the OAuth callback handler
MyQWebEnginePage now overrides javaScriptConsoleMessage (Qt6) and certificateError (Qt5) to log SSL/JS errors via LOG_WARN

// Before: silent blank page
void DialogInfoWebView::pageLoaded(bool ok) {
    if (!ok) return;  // ← user sees nothing
    ...
}

// After: actionable error with log-file hint
void DialogInfoWebView::pageLoaded(bool ok) {
    if (!ok) {
        LOG_WARN("DialogInfoWebView", "Page failed to load: " + currentUrl);
        if (usedForIntervalsIcu || usedForStrava || usedForTrainingPeaks) {
            m_showingErrorPage = true;
            ui->webView->setHtml(buildErrorPageHtml(currentUrl));
        }
        return;
    }
    ...
}

Structured logging across network/BLE layer

Persistence DAOs (extrequest, achievementdao, sensordao, radiodao, userdao, intervalsicudao, intervals_icu_service, intervalsicuservice, versiondao)

Null NetworkManagerWS pointer now emits LOG_WARN before every network call (previously either silent crash risk or bare qWarning())
File-open failures upgraded to LOG_WARN with delete file; delete multiPart to fix accompanying memory leaks

BLE (btle_hub.cpp)

Replaced #include <QDebug> with logger.h
Connect/disconnect/discovery lifecycle → LOG_INFO; controller errors → LOG_WARN

UI callbacks (mainwindow.cpp, tab_intervals_icu.cpp, workoutdialog.cpp, dialoglogin.cpp)

All qDebug()/qWarning() in network reply error branches upgraded to LOG_WARN, ensuring they are written to the log file at the default Info threshold

Logging Settings UI

dialogmainwindowconfig.cpp/.h — new "Logging" page (6th item in Settings):

Log level selector: Verbose / Debug / Info / Warn / Error
File logging toggle + path field with Browse and Open buttons
OS-specific default path hint shown inline:
- Linux: ~/.local/share/MaximumTrainer/MaximumTrainer.log
- macOS: ~/Library/Application Support/MaximumTrainer/MaximumTrainer.log
- Windows: %APPDATA%\MaximumTrainer\MaximumTrainer.log
Persisted via existing Logger::saveConfig() / loadConfig() on dialog accept

Documentation

docs/user-guide.html — new 🗒️ Log Files & Troubleshooting section (added to sidebar TOC):

Step-by-step instructions for enabling file logging from the Settings → Logging tab
OS-specific default log file paths table (Windows / macOS / Linux)
Troubleshooting table for the Intervals.icu blank login page covering blank page, error message, SSL error, and token exchange failure
New Logging row added to the Settings table that cross-links to the new section

README.md — new Log Files section with the OS-specific path table and a link to the full user-guide section.

…nk login page Agent-Logs-Url: https://github.com/MaximumTrainer/MaximumTrainer_Redux/sessions/fa334fac-bbb3-4f66-808f-5389fa2b823f Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

MaximumTrainer · 2026-04-04T09:45:42Z

@copilot ensure that user guide is updated with os specific log file location

Agent-Logs-Url: https://github.com/MaximumTrainer/MaximumTrainer_Redux/sessions/e150cb1c-9798-4e08-93cb-727cffa32134 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot · 2026-04-04T09:49:21Z

@copilot ensure that user guide is updated with os specific log file location

Done in commit e637f7f. Two docs updated:

docs/user-guide.html — new 🗒️ Log Files & Troubleshooting section (added to the TOC under App) covering:

How to enable file logging (Preferences → Logging tab)
OS-specific default paths table:
- Windows: %APPDATA%\MaximumTrainer\MaximumTrainer.log
- macOS: ~/Library/Application Support/MaximumTrainer/MaximumTrainer.log
- Linux: ~/.local/share/MaximumTrainer/MaximumTrainer.log
Troubleshooting table for the Intervals.icu blank login page (blank page, error message, SSL error, token exchange failure)

The Settings table also has a new Logging row that links to this section.

README.md — new Log Files section with the same OS-specific path table and a link to the full user-guide section.

Copilot

Pull request overview

This PR improves observability and user experience around Intervals.icu OAuth/login failures by adding consistent structured logging across UI, BLE, and networking layers, plus a new Settings UI for configuring log level and file logging.

Changes:

Add a user-friendly OAuth failure error page + additional WebEngine load/SSL/JS-console logging.
Replace scattered qDebug()/qWarning() usage with LOG_* macros and add “NetworkManagerWS not available” warnings across DAO/service calls.
Add a new “Logging” settings page to configure log level and file logging path.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/ui/workoutdialog.cpp	Replace warning/debug prints with `LOG_WARN` for VLC init, BLE errors, and retry exhaustion paths.
src/ui/tab_intervals_icu.cpp	Add `LOG_WARN` on Intervals.icu calendar/download/sync network failures while preserving user-facing status text.
src/ui/mainwindow.cpp	Upgrade network error branches (radio/uploads/downloads/webchannel JS file) to `LOG_WARN` and remove noisy debug output.
src/ui/dialogmainwindowconfig.h	Add declarations for new logging settings page helpers and widget members.
src/ui/dialogmainwindowconfig.cpp	Implement new “Logging” settings page (level + file logging path/browse/open) and persist via `Logger`.
src/ui/dialoglogin.cpp	Log connectivity-check failure via `LOG_WARN`.
src/ui/dialoginfowebview.h	Add load-start slot, error-page builder, and `m_showingErrorPage` guard flag.
src/ui/dialoginfowebview.cpp	Log each load attempt; render an inline error page on `loadFinished(ok=false)` to avoid blank OAuth webview.
src/ui/components/myqwebenginepage.h	Add SSL logging for Qt5 (certificateError) and JS-console logging for Qt6.
src/persistence/db/versiondao.cpp	Add null `NetworkManagerWS` check + bump release-check request log to INFO.
src/persistence/db/userdao.cpp	Add null `NetworkManagerWS` check and replace debug prints with `LOG_DEBUG`.
src/persistence/db/sensordao.cpp	Add null `NetworkManagerWS` check and replace debug output with `LOG_DEBUG`.
src/persistence/db/radiodao.cpp	Add null `NetworkManagerWS` check and replace debug output with `LOG_DEBUG`.
src/persistence/db/intervalsicuservice.cpp	Add null manager checks and upgrade file/JSON errors to `LOG_WARN` for Intervals.icu service.
src/persistence/db/intervalsicudao.cpp	Replace `qWarning()` null-manager messages with `LOG_WARN`.
src/persistence/db/intervals_icu_service.cpp	Replace `qWarning()` null-manager messages with `LOG_WARN`.
src/persistence/db/extrequest.cpp	Add `logger.h`, add null-manager warnings, remove noisy debug output, and improve file-open failure logging.
src/persistence/db/achievementdao.cpp	Add `logger.h`, add null-manager warnings, replace debug output with `LOG_DEBUG`.
src/btle/btle_hub.cpp	Replace `QDebug` output with structured `LOG_INFO`/`LOG_DEBUG`/`LOG_WARN` for BLE lifecycle and errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-04T09:49:47Z

    auto *mgr = qApp->property("NetworkManagerWS")
                    .value<QNetworkAccessManager *>();
+    if (!mgr) {
+        LOG_WARN("IntervalsIcuService", QStringLiteral("uploadActivity: NetworkManagerWS not available"));
+        return nullptr;
+    }


In IntervalsIcuService::uploadActivity(), if NetworkManagerWS is null the function returns nullptr after allocating multiPart (and parenting the QFile to it). This leaks multiPart/file. Clean up allocated resources before returning (e.g., delete multiPart) or move the manager-null check before allocating multipart/file.

Copilot · 2026-04-04T09:49:48Z

    QFile *file = new QFile(pathToZip);
-    if (!file->open(QIODevice::ReadOnly))
+    if (!file->open(QIODevice::ReadOnly)) {
+        LOG_WARN("ExtRequest", QStringLiteral("selfloopsUploadFile: cannot open file: ") + pathToZip);


In ExtRequest::selfloopsUploadFile(), the file-open failure path returns nullptr without deleting the newly allocated QFile and QHttpMultiPart, causing a memory leak. Delete the QFile (and the multipart, since no reply will own it) before returning, or restructure with smart pointers/parenting so early returns are safe.

Suggested change

LOG_WARN("ExtRequest", QStringLiteral("selfloopsUploadFile: cannot open file: ") + pathToZip);

LOG_WARN("ExtRequest", QStringLiteral("selfloopsUploadFile: cannot open file: ") + pathToZip);

delete file;

delete multiPart;

Copilot · 2026-04-04T09:49:48Z

+    /// In Qt 6 the certificate-error signal is preferred; this override
+    /// provides a fallback log for builds that still use the virtual.


The Qt6 block comment above javaScriptConsoleMessage() mentions a “certificate-error signal” and “fallback … for builds that still use the virtual”, but the override being added is for JavaScript console messages. Update the comment to match the behavior (JS console logging) to avoid confusion during maintenance.

Suggested change

/// In Qt 6 the certificate-error signal is preferred; this override

/// provides a fallback log for builds that still use the virtual.

/// In Qt 6, override the JavaScript console message handler to log

/// console output, including errors, with source and line information.

Copilot · 2026-04-04T09:49:48Z

+    const bool enabled = m_checkFileLogging->isChecked();
+    m_editLogFilePath->setEnabled(enabled);
+    m_btnBrowseLog->setEnabled(enabled);
+    m_btnOpenLog->setEnabled(enabled && !Logger::instance().logFilePath().isEmpty());
+}


Logging settings UI treats an empty log-file path as “(default path)”, but the Open button is disabled when the line-edit is empty and onOpenLogFileClicked() won’t open the default path. Since Logger::setFileLogging(true, "") resolves to /MaximumTrainer.log, consider enabling Open when empty+enabled and opening the computed default path (or populating the field with the resolved default when toggled on) so the UI matches actual behavior.

MaximumTrainer · 2026-04-04T09:49:56Z

@copilot apply changes based on the comments in this thread

…utton default path Agent-Logs-Url: https://github.com/MaximumTrainer/MaximumTrainer_Redux/sessions/9ec11540-b750-4632-9b68-3d7c5a707c67 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot · 2026-04-04T09:55:24Z

@copilot apply changes based on the comments in this thread

Applied all 4 review fixes in commit 0cbb05a:

intervalsicuservice.cpp — delete multiPart (owns file via parenting) before returning when NetworkManagerWS is null.
extrequest.cpp — delete file; delete multiPart in the file-open failure path of selfloopsUploadFile().
myqwebenginepage.h — corrected the Qt6 override comment from "certificate-error signal / fallback" to accurately describe JavaScript console message logging.
dialogmainwindowconfig.cpp — "Open log file" button is now enabled whenever file logging is checked (empty-path guard removed); onOpenLogFileClicked() resolves AppDataLocation/MaximumTrainer.log as the default when the path field is empty, matching Logger's own default resolution.

MaximumTrainer · 2026-04-04T09:58:19Z

@copilot investigate & fix the broken tests and builds

…sources Agent-Logs-Url: https://github.com/MaximumTrainer/MaximumTrainer_Redux/sessions/376aa095-a3df-4953-a915-139a273b6e41 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot · 2026-04-04T10:03:36Z

@copilot investigate & fix the broken tests and builds

Fixed in commit 28dd4eb. The failures were linker errors on all three platforms:

undefined reference to `Logger::instance()'
undefined reference to `Logger::logLevel() const'
undefined reference to `Logger::log(LogLevel, ...)'

intervals_icu_service.cpp and intervalsicudao.cpp now use LOG_* macros, but the standalone test .pro files that compile these sources directly didn't link logger.cpp. Fixed by adding logger.cpp/logger.h to:

tests/intervals_icu/intervals_icu_tests.pro
tests/intervals_icu/intervals_icu_dao_bearer_tests.pro
tests/intervals_icu_integration/intervals_icu_integration_tests.pro
tests/btle/btle_tests.pro (proactive — btle_hub.cpp also uses Logger)

MaximumTrainer · 2026-04-04T10:10:38Z

@copilot apply changes based on the comments in this thread

Copilot · 2026-04-04T10:12:17Z

@copilot apply changes based on the comments in this thread

All 4 changes from that review thread were already applied in commit 0cbb05a:

intervalsicuservice.cpp — delete multiPart before early return (memory leak fix)
extrequest.cpp — delete file; delete multiPart in file-open failure path
myqwebenginepage.h — comment corrected to describe JS console logging
dialogmainwindowconfig.cpp — Open button enabled when path is empty; onOpenLogFileClicked() resolves the default AppDataLocation/MaximumTrainer.log path when the field is blank

The subsequent CI linker failures (undefined reference to Logger::instance()) were fixed in commit 28dd4eb by adding logger.cpp to the test .pro files that compile sources using LOG_* macros. The current action_required build status is GitHub's environment protection pausing the secrets-gated integration tests for approval — not a build or compile failure.

MaximumTrainer · 2026-04-04T10:21:40Z

@copilot investigate & fix build_wasm failure

…o fix WASM build Agent-Logs-Url: https://github.com/MaximumTrainer/MaximumTrainer_Redux/sessions/8b2e7d33-bf75-4ebe-b5be-5fba2f81c327 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot · 2026-04-04T10:23:40Z

@copilot investigate & fix build_wasm failure

Fixed in commit aead86c.

Root cause: myqwebenginepage.h had #include <QWebEngineCertificateError> as an unconditional top-level include, but the WASM build (Qt 6.6.3) has no stub for that header in src/ui/wasm_stubs/. The header is only used in the #else (Qt5) branch of the certificateError override — the Qt6/WASM code path never uses it.

Fix: Moved the include inside the #else block so it's only seen by the preprocessor when building for Qt5:

#else
#   include <QWebEngineCertificateError>
    bool certificateError(const QWebEngineCertificateError &error) override { ... }
#endif

The WASM build uses Qt 6.6.3 so the #else branch is never compiled there, and the missing header is no longer referenced.

MaximumTrainer · 2026-04-04T10:30:46Z

@copilot now fix the linkx build: https://github.com/MaximumTrainer/MaximumTrainer_Redux/actions/runs/23976983709/job/69935590839?pr=116

MaximumTrainer · 2026-04-04T10:32:56Z

@copilot investigate & fix broken wasm build: https://github.com/MaximumTrainer/MaximumTrainer_Redux/actions/runs/23976983709/job/69935590804?pr=116

…x Linux/Qt5 build Agent-Logs-Url: https://github.com/MaximumTrainer/MaximumTrainer_Redux/sessions/aeac89bf-3877-49f4-a7d6-a7b1f1d81ef1 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot · 2026-04-04T10:33:53Z

@copilot now fix the linkx build: https://github.com/MaximumTrainer/MaximumTrainer_Redux/actions/runs/23976983709/job/69935590839?pr=116

Fixed in commit 663ded8.

Root cause: The Linux build uses Qt5 (installed via apt: qtbase5-dev, qtwebengine5-dev). On Qt5, the #else block (containing certificateError) is compiled. In the previous commit (aead86c), I placed #include <QWebEngineCertificateError> inside the class body (inside the #else block). This caused QWebEngineCertificateError to be declared within MyQWebEnginePage's scope, making the override signature MyQWebEnginePage::QWebEngineCertificateError instead of the expected global ::QWebEngineCertificateError — which doesn't match the virtual base method.

Fix: Move the include to the top of the file at global scope, guarded by #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0):

// Top of file (outside class)
#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
#include <QWebEngineCertificateError>
#endif

// Inside class
#else
    bool certificateError(const QWebEngineCertificateError &error) override { ... }
#endif

This correctly handles all three targets:

Qt5 / Linux: header included at global scope → override resolves correctly
Qt6 / Linux, macOS, Windows: header skipped, #else block not compiled
Qt6 WASM: same as Qt6 — no stub needed, #else block skipped

Agent-Logs-Url: https://github.com/MaximumTrainer/MaximumTrainer_Redux/sessions/edfe9106-4706-4512-9c8a-d15d72e2fbbb Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot · 2026-04-04T10:36:51Z

@copilot investigate & fix broken wasm build: https://github.com/MaximumTrainer/MaximumTrainer_Redux/actions/runs/23976983709/job/69935590804?pr=116

Fixed in commit 726b439.

Root cause: The WASM build uses Qt 6.6.3 with stub classes for QtWebEngineWidgets (in src/ui/wasm_stubs/). The stub's QWebEnginePage doesn't define JavaScriptConsoleMessageLevel or ErrorMessageLevel, so the Qt6 #if branch in javaScriptConsoleMessage failed to compile — even though the WASM version never uses real WebEngine.

Fix: Wrapped both WebEngine overrides in #ifndef GC_WASM_BUILD (the define injected by the WASM build via -DGC_WASM_BUILD):

#ifndef GC_WASM_BUILD
#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
    void javaScriptConsoleMessage(...) override { ... }   // Qt6 desktop
#else
    bool certificateError(...) override { ... }           // Qt5 Linux
#endif
#endif // GC_WASM_BUILD

All three targets now compile cleanly:

Qt5 / Linux: GC_WASM_BUILD not set → certificateError override compiled
Qt6 / desktop: GC_WASM_BUILD not set → javaScriptConsoleMessage override compiled
Qt6 / WASM: GC_WASM_BUILD defined → both overrides skipped; stub QWebEnginePage used without any missing types

Initial plan

a1d1d02

Copilot AI assigned Copilot and MaximumTrainer Apr 4, 2026

Copilot started work on behalf of MaximumTrainer April 4, 2026 09:08 View session

Copilot AI linked an issue Apr 4, 2026 that may be closed by this pull request

unable to login to intervals.icu #115

Closed

MaximumTrainer requested a review from Copilot April 4, 2026 09:45

Copilot AI changed the title ~~[WIP] Add error logging for login issue on intervals.icu~~ Fix blank intervals.icu OAuth login page and add structured error logging across all network/BLE calls Apr 4, 2026

Copilot AI requested a review from MaximumTrainer April 4, 2026 09:45

Copilot finished work on behalf of MaximumTrainer April 4, 2026 09:45

Copilot started reviewing on behalf of MaximumTrainer April 4, 2026 09:45 View session

Copilot started work on behalf of MaximumTrainer April 4, 2026 09:45 View session

docs: add OS-specific log file locations to user guide and README

e637f7f

Agent-Logs-Url: https://github.com/MaximumTrainer/MaximumTrainer_Redux/sessions/e150cb1c-9798-4e08-93cb-727cffa32134 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot AI reviewed Apr 4, 2026

View reviewed changes

Copilot AI changed the title ~~Fix blank intervals.icu OAuth login page and add structured error logging across all network/BLE calls~~ Fix blank intervals.icu OAuth login page, add structured error logging across all network/BLE calls, and document log file locations Apr 4, 2026

Copilot finished work on behalf of MaximumTrainer April 4, 2026 09:50

Copilot started work on behalf of MaximumTrainer April 4, 2026 09:50 View session

Copilot stopped work on behalf of MaximumTrainer due to an error April 4, 2026 09:56
Failed to get response from the AI model; retried n times (total retry wait time: <duration>) Last error: Unknown error

Copilot started work on behalf of MaximumTrainer April 4, 2026 09:58 View session

fix: add logger.cpp to test .pro files that compile Logger-dependent …

28dd4eb

…sources Agent-Logs-Url: https://github.com/MaximumTrainer/MaximumTrainer_Redux/sessions/376aa095-a3df-4953-a915-139a273b6e41 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot finished work on behalf of MaximumTrainer April 4, 2026 10:04

Copilot started work on behalf of MaximumTrainer April 4, 2026 10:10 View session

Copilot finished work on behalf of MaximumTrainer April 4, 2026 10:12

Copilot started work on behalf of MaximumTrainer April 4, 2026 10:21 View session

Copilot finished work on behalf of MaximumTrainer April 4, 2026 10:24

Copilot started work on behalf of MaximumTrainer April 4, 2026 10:30 View session

Copilot finished work on behalf of MaximumTrainer April 4, 2026 10:34

Copilot started work on behalf of MaximumTrainer April 4, 2026 10:34 View session

fix: guard WebEngine overrides with GC_WASM_BUILD to fix WASM build

726b439

Agent-Logs-Url: https://github.com/MaximumTrainer/MaximumTrainer_Redux/sessions/edfe9106-4706-4512-9c8a-d15d72e2fbbb Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot finished work on behalf of MaximumTrainer April 4, 2026 10:37

MaximumTrainer marked this pull request as ready for review April 4, 2026 10:58

MaximumTrainer merged commit ab6c215 into master Apr 4, 2026
22 checks passed

MaximumTrainer deleted the copilot/add-error-logging-for-login branch April 4, 2026 10:58

		/// In Qt 6 the certificate-error signal is preferred; this override
		/// provides a fallback log for builds that still use the virtual.

Conversation

Copilot AI commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Blank login page fix

Structured logging across network/BLE layer

Logging Settings UI

Documentation

Uh oh!

MaximumTrainer commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

MaximumTrainer commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

MaximumTrainer commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

MaximumTrainer commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

MaximumTrainer commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

MaximumTrainer commented Apr 4, 2026

Uh oh!

MaximumTrainer commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 4, 2026 •

edited

Loading