test: verify unit test coverage for TemplateParser, PolicyParser, and PolicyExpressionEvaluator#116
Merged
MaximumTrainer merged 1 commit intomainfrom Apr 20, 2026
Conversation
Closed
13 tasks
Copilot
AI
changed the title
[WIP] Add unit tests for KosliTemplateParser, KosliPolicyParser, and PolicyExpressionEvaluator
test: verify unit test coverage for TemplateParser, PolicyParser, and PolicyExpressionEvaluator
Apr 20, 2026
MaximumTrainer
requested review from
Copilot
and removed request for
MaximumTrainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue requested unit tests for three compliance evaluation components (
TemplateParser,PolicyParser,PolicyExpressionEvaluator) which are critical to the policy enforcement pipeline.Upon investigation, all required test files already exist in the repository and fully satisfy every requirement from the issue:
TemplateParserTest(7 tests) — trail/artifact attestation parsing,ifCondition, blank/invalid YAML, missingversiondefaulting to 1PolicyParserTest(8 tests) —provenance.required,trail-compliance.required, attestation list withifcondition, blank/invalid YAMLPolicyExpressionEvaluatorTest(17 tests) — equality/regex/existence expressions,not/and/orcompounds, malformed expressions returningfalsewithout exceptionsAll 32 tests pass. No new code was required.