Fix HANA get_columns on HANA Cloud (#153)#182
Merged
Conversation
SYS.CONSTRAINT_COLUMNS does not exist in current HANA Cloud schemas, and SYS.COLUMNS has been deprecated since HANA 2 SP03. SYS.CONSTRAINTS already exposes COLUMN_NAME and IS_PRIMARY_KEY per column, so the join can be dropped entirely. Fixes #153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153.
HANA Cloud's
SYS.CONSTRAINT_COLUMNSdoesn't exist, andSYS.COLUMNShas been deprecated since HANA 2 SP03.SYS.CONSTRAINTSalready hasCOLUMN_NAMEandIS_PRIMARY_KEYper column, so we can drop the join and read columns fromSYS.TABLE_COLUMNSinstead.Added mocked unit tests for
get_columnsso we'd catch a regression — there are no HANA integration tests yet (SAP doesn't ship a Docker image, so the usual compose setup doesn't cover it).