Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Move paramiko and sshtunnel from core dependecies to optional [ssh] extra.
-Users who run SSH tunneling can install with pip install sqlit-tui[ssh]
-Guided installation on SSH tab in connection modal.
macOs/windows will save 57% package size
Linux will save 22%
The larger savings on macOS/Windows come from dropping cryptography (4.5 MB), which is only needed by paramiko on those platforms (keyring uses native OS credential stores on macos/windows).
https://github.com/jaraco/keyring/blob/main/pyproject.toml
Will result in faster installs, especially for pipx installs. Majority of users wont use ssh tunneling