Use move_cursor instead of select_node#206
Merged
Merged
Conversation
Owner
|
Nice fix. Thanks. |
koianaoki
pushed a commit
to koianaoki/sqlit
that referenced
this pull request
May 22, 2026
Tree.move_cursor reads node._line, which is only set during the next layout pass — not when add() runs. Calling it synchronously right after the snapshot restore in action_tree_filter_close sent the cursor to whatever node currently sat at line 0 (usually the first connection). Defer the move via call_after_refresh. Also adds move_cursor to the test MockTree so the existing filter tests stop AttributeError-ing after PR Maxteabag#206.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your great work 👍 sqlit is such a joy to use!
When filtering the "Explorer" tree it currently uses
select_nodefor each match, which results in the node expanding and collapsing each time.The change I've made is to use
move_cursorinstead.Before and after:
demo1.mp4