Skip to content

Update devcontainer.json#14

Merged
MayMeow merged 1 commit intomainfrom
MayMeow-patch-2
May 31, 2025
Merged

Update devcontainer.json#14
MayMeow merged 1 commit intomainfrom
MayMeow-patch-2

Conversation

@MayMeow
Copy link
Copy Markdown
Owner

@MayMeow MayMeow commented May 9, 2025

No description provided.

@MayMeow MayMeow requested a review from Copilot May 31, 2025 20:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the devcontainer configuration by changing the base image and removing the separate PHP feature.

  • Update the container image from a universal container to a PHP SDK image.
  • Remove the standalone PHP feature configuration.
Comments suppressed due to low confidence (2)

.devcontainer/devcontainer.json:3

  • Confirm that removing the PHP feature is intentional and update the project documentation or commit notes to reflect this change if necessary.
"ghcr.io/devcontainers/features/php:1": {}

.devcontainer/devcontainer.json:2

  • Ensure that the updated image 'ghcr.io/maymeow/php/sdk:8.4' provides all the necessary tools and configurations previously supplied by the universal image.
"image": "ghcr.io/maymeow/php/sdk:8.4",

Copy link
Copy Markdown
Owner Author

@MayMeow MayMeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it provides all thatt is needed

@MayMeow MayMeow merged commit a3649a1 into main May 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants