Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the devcontainer configuration by changing the base image and removing the separate PHP feature.
- Update the container image from a universal container to a PHP SDK image.
- Remove the standalone PHP feature configuration.
Comments suppressed due to low confidence (2)
.devcontainer/devcontainer.json:3
- Confirm that removing the PHP feature is intentional and update the project documentation or commit notes to reflect this change if necessary.
"ghcr.io/devcontainers/features/php:1": {}
.devcontainer/devcontainer.json:2
- Ensure that the updated image 'ghcr.io/maymeow/php/sdk:8.4' provides all the necessary tools and configurations previously supplied by the universal image.
"image": "ghcr.io/maymeow/php/sdk:8.4",
MayMeow
commented
May 31, 2025
Owner
Author
MayMeow
left a comment
There was a problem hiding this comment.
yes it provides all thatt is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.