Implement tests, fixes, and new functionality for OkioFileKache#157
Merged
MSDarwish2000 merged 3 commits intomainfrom Dec 30, 2023
Merged
Implement tests, fixes, and new functionality for OkioFileKache#157MSDarwish2000 merged 3 commits intomainfrom
OkioFileKache#157MSDarwish2000 merged 3 commits intomainfrom
Conversation
This commit also implements fixes for clear() and re-putting an existing value
This version stores keys in its plain form instead of transformed form. It also checks for strategy used
- The commit adds tests for newly added functions - The commit also fixes removal of cancelled putting
MSDarwish2000
force-pushed
the
refactor/file-kache-tests
branch
from
67ff0c9 to
c4b0d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
OkioFileKache(fixes Implementing tests (and maybe bug fixes) forFileKacheto get ready for stable v2.0.0 #110)clear()to close the cacheInMemoryKache