Skip to content

Conversation

@bjwtaylor
Copy link

@bjwtaylor bjwtaylor commented Apr 14, 2025

Description

Remove include/mbedtls/compat-2.x.h and its reference in check_names.py. resolves #10088 depends Mbed-TLS/mbedtls-framework#160

PR checklist

  • changelog provided | not required because: TBC
  • development PR provided #here
  • TF-PSA-Crypto PRnot required because: No changes
  • framework PR provided remove compat-2.x.h mbedtls-framework#160
  • 3.6 PR not required because: No backports
  • tests not required because: No changes

@bjwtaylor bjwtaylor force-pushed the remove-compat-2 branch 3 times, most recently from 1d2c084 to 772f107 Compare April 23, 2025 08:11
@bjwtaylor bjwtaylor marked this pull request as ready for review April 25, 2025 14:32
@bjwtaylor bjwtaylor added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 25, 2025
Copy link
Contributor

@felixc-arm felixc-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as my assumption that this should not be backported to 3.6 is correct 👍

Ben Taylor added 4 commits May 8, 2025 14:55
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
@valeriosetti valeriosetti self-requested a review May 21, 2025 12:58
@valeriosetti valeriosetti added approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels May 21, 2025
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue May 23, 2025
Merged via the queue into Mbed-TLS:development with commit 127c78e May 23, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Development to Done in Roadmap pull requests (new board) May 23, 2025
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jul 7, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)

Development

Successfully merging this pull request may close these issues.

Remove compat-2.x.h

4 participants