DeleteUserHandler: roll back nested transaction if any exception occurs. #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blued-gear
commented
Jan 22, 2026
|
|
||
| $this->entityManager->commit(); | ||
| } catch (\Exception $e) { | ||
| $this->entityManager->rollback(); |
Collaborator
Author
There was a problem hiding this comment.
does this also need a $this->managerRegistry->resetManager();? As this is a savepoint (nested transaction), I'm not sure.
Member
There was a problem hiding this comment.
I think it is not strictly necessary, as this is the end of the method and the entitymanager will be disposed afterwards anyways...
Member
There was a problem hiding this comment.
also if you catched the error?
Collaborator
Author
There was a problem hiding this comment.
it is thrown right after this, so it should not make a difference
BentiGorlich
approved these changes
Jan 25, 2026
blued-gear
deleted the
fix/end_transaction_properly_in_deleteuserhandler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only place in the codebase where I found an opened transaction without an accompanying rollback.
Might fix #1846