Improve performance of RemoveRemoteMediaCommand#2064
Merged
BentiGorlich merged 4 commits intomainfrom Mar 29, 2026
Merged
Conversation
Member
BentiGorlich
commented
Mar 25, 2026
BentiGorlich
commented
- for some reason doctrine takes a long time to compute the changeset in this case. Use a native statement instead that is a lot faster
- for some reason doctrine takes a long time to compute the changeset in this case. Use a native statement instead that is a lot faster
BentiGorlich
added
backend
blued-gear
reviewed
Mar 25, 2026
| $image->downloadedAt = null; | ||
| $this->entityManager->persist($image); | ||
| $this->entityManager->flush(); | ||
| $sql = 'UPDATE image SET file_path = NULL, downloaded_at = NULL WHERE id = :id'; |
Collaborator
There was a problem hiding this comment.
the two properties should still be set to null, in case code somewhere else uses them for checks or so
blued-gear
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.