Fix support for image property on Page type, add support for string#2111
Merged
BentiGorlich merged 2 commits intomainfrom Apr 23, 2026
Merged
Fix support for image property on Page type, add support for string#2111BentiGorlich merged 2 commits intomainfrom
image property on Page type, add support for string#2111BentiGorlich merged 2 commits intomainfrom
Conversation
- When a `Page` ActivityPub object contains only an `image` property, but no `attachment` property our code threw an error - Add support for either `attachment` or `image` property to contain only a string (Ghost does this for example)
BentiGorlich
added
bug
blued-gear
reviewed
Apr 23, 2026
blued-gear
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PageActivityPub object contains only animageproperty, but noattachmentproperty our code threw an errorattachmentorimageproperty to contain only a string (Ghost does this for example)With this change an AP-Object like this: https://www.shoptechblog.com/.ghost/activitypub/article/38919605-5b90-4b0b-ad3c-5991a889855c
will properly work and get the image attached
Also connection to #2107